From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6 Date: Fri, 5 Oct 2018 05:17:56 -0700 Message-ID: <2b4d849f-9bd3-28aa-7a1c-ad61ab584041@gmail.com> References: <20181005030755.31217-1-dsahern@kernel.org> <20181004.215507.1973705600397352485.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, weiwan@google.com, sd@queasysnail.net, xiyou.wangcong@gmail.com, dsahern@gmail.com To: David Miller , dsahern@kernel.org Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:33150 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727558AbeJETQ0 (ORCPT ); Fri, 5 Oct 2018 15:16:26 -0400 Received: by mail-pf1-f195.google.com with SMTP id d4-v6so5023562pfn.0 for ; Fri, 05 Oct 2018 05:17:58 -0700 (PDT) In-Reply-To: <20181004.215507.1973705600397352485.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/04/2018 09:55 PM, David Miller wrote: > From: David Ahern > Date: Thu, 4 Oct 2018 20:07:50 -0700 > >> From: David Ahern >> >> As part of the IPv6 fib info refactoring, the intent was to make metrics >> handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy >> led to confusion and a couple of incomplete attempts at finding and >> fixing the resulting memory leak which was ultimately resolved by >> ce7ea4af0838 ("ipv6: fix memory leak on dst->_metrics"). >> >> Refactor metrics hanlding make the code really identical for v4 and v6, >> and add a few test cases. > > Looks nice, series applied, thanks David. > Does not look well tested and reviewed to me.