From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net 0/7] net: usb: Check for Wake-on-LAN modes Date: Wed, 26 Sep 2018 17:15:11 -0700 Message-ID: <2b56866a-e230-6f89-661f-36dcf8a47930@gmail.com> References: <20180924205420.31309-1-f.fainelli@gmail.com> <20180926.171218.1890476375628867560.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net, keescook@chromium.org, akurz@blala.de, hayeswang@realtek.com, kai.heng.feng@canonical.com, grundler@chromium.org, zhongjiang@huawei.com, bigeasy@linutronix.de, ran.wang_1@nxp.com, edumazet@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180926.171218.1890476375628867560.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/26/2018 05:12 PM, David Miller wrote: > From: Florian Fainelli > Date: Mon, 24 Sep 2018 13:54:13 -0700 > >> Most of our USB Ethernet drivers don't seem to be checking properly >> whether the user is supplying a correct Wake-on-LAN mode to enter, so >> the experience as an user could be confusing, since it would generally >> lead to either no wake-up, or the device not being marked for wake-up. >> >> Please review! > > I saw some discussion on patch #3, is there going to be a new version > of this series or should I apply this one? I will be sending a v2, please discard this one, thanks! -- Florian