Re: [net 09/10] net/mlx5e: Don't offload internal port if filter device is out device

[Jianbo Liu <jianbol@nvidia.com>]

On 11/6/2024 3:17 PM, Gerald Yang wrote:
>>>> From: Jianbo Liu <jianbol@nvidia.com>
>>>>
>>>> In the cited commit, if the routing device is ovs internal port, the
>>>> out device is set to uplink, and packets go out after encapsulation.
>>>>
>>>> If filter device is uplink, it can trigger the following syndrome:
>>>> mlx5_core 0000:08:00.0: mlx5_cmd_out_err:803:(pid 3966): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0xcdb051), err(-22)
>>>>
>>>> Fix this issue by not offloading internal port if filter device is out
>>>> device. In this case, packets are not forwarded to the root table to
>>>> be processed, the termination table is used instead to forward them
>>>> from uplink to uplink.
>>>
>>> This patch breaks forwarding for in production use cases with hardware
>>> offload enabled. In said environments, we do not see the above
>>> mentioned syndrome, so it appears the logic change in this patch hits
>>> too wide.
>>>
>>
>> Thank you for the report. We'll send fix or maybe revert later.
>>
>> Jianbo
> 
> Hi Jianbo,
> 
> Thanks for checking this, since this issue affects our production environment,
> is it possible to revert this commit first, if it would take some time to fix it?
> 

Hi Gerald,

I already sent the fix to Frode last week. Have you tested it?
Better to use the fix instead of reverting it, right?

Thanks!
Jianbo

> Thanks,
> Gerald
>