From: Ahmed Zaki <ahmed.zaki@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<andrew+netdev@lunn.ch>, <edumazet@google.com>,
<horms@kernel.org>, <pabeni@redhat.com>, <davem@davemloft.net>,
<michael.chan@broadcom.com>, <tariqt@nvidia.com>,
<anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,
<jdamato@fastly.com>, <shayd@nvidia.com>,
<akpm@linux-foundation.org>, <shayagr@amazon.com>,
<kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config
Date: Tue, 21 Jan 2025 07:54:13 -0700 [thread overview]
Message-ID: <2b9ea13d-9b39-451e-8759-148b6716e464@intel.com> (raw)
In-Reply-To: <20250120170358.3f4181a6@kernel.org>
On 2025-01-20 6:03 p.m., Jakub Kicinski wrote:
> On Fri, 17 Jan 2025 17:33:30 -0700 Ahmed Zaki wrote:
>> Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
>> after reset. However, since there can be only one IRQ affinity notifier
>> for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
>> management in the core (which also registers separate IRQ affinity
>> notifiers).
>>
>> Move the IRQ affinity management to the napi struct. This way we can have
>> a unified IRQ notifier to re-apply the user-set affinity and also manage
>> the ARFS rmaps. Patches 1 and 2 move the ARFS rmap management to CORE.
>> Patch 3 adds the IRQ affinity mask to napi_config and re-applies the mask
>> after reset. Patches 4-6 use the new API for bnxt, ice and idpf drivers.
>
> Sorry for not-super-in-depth reviews, the patches didn't apply for me :(
> But feels like we are pretty close.
No worries, I will rebase and send when net-next re-opens.
Thanks for the review.
next prev parent reply other threads:[~2025-01-21 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 0:33 [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 1/5] net: move ARFS rmap management to core Ahmed Zaki
2025-01-21 0:59 ` Jakub Kicinski
2025-01-21 14:52 ` Ahmed Zaki
2025-01-23 19:28 ` Joe Damato
2025-01-23 20:13 ` Ahmed Zaki
2025-01-23 20:20 ` Joe Damato
2025-01-18 0:33 ` [PATCH net-next v6 2/5] net: napi: add CPU affinity to napi_config Ahmed Zaki
2025-01-21 1:03 ` Jakub Kicinski
2025-01-23 20:18 ` Joe Damato
2025-02-03 21:32 ` Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 3/5] bnxt: use napi's irq affinity Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 4/5] ice: " Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 5/5] idpf: " Ahmed Zaki
2025-01-21 1:03 ` [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config Jakub Kicinski
2025-01-21 14:54 ` Ahmed Zaki [this message]
2025-01-23 20:27 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b9ea13d-9b39-451e-8759-148b6716e464@intel.com \
--to=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayagr@amazon.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).