From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0052127E3A for ; Fri, 16 Aug 2024 15:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723822167; cv=none; b=LV9IyQDOBPdqIcZlVEskWvrv4mgz1nyoUl4+YtR5QIf7fwu2nMAYJz3hdTlNmu9z5a9U+nUMD6h92UBK5EBi3bF37XgvhrHN7el6g8JNaZd3GfYrlKHZIwdViMXR6ZKzwiz1kSnC2BFZBj2vRkDGcD2LtPGw7V0KIVzRcVM8AM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723822167; c=relaxed/simple; bh=Dh/TqOKJ8mHwkl8blqkDVlbuxeVntZZ9shMGr4OSnvQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ELppl0wlxX7sRbQdsyNCIzm96wk+Tq8R4vX0UShJfmGmrPopKhbBfmAIQcDJq/thZdsmeuEAMwd4O08siL7XpPOLYsl77/l/CurMVAiwpR3aZwhXfypiSOUyRqbUmK0qi3OGJYPGCj3fluL0mzBxjvUdE9MMUIKclaYnE3cazBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=none smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=KbZARtv0; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nbd.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="KbZARtv0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dQYD/qZQ3mvhTuaq0enXT1CiNk17PagSiXwYv4Je7+E=; b=KbZARtv0mHnnNMl3Jnqclri56z f1/lUA8HmqqigG5ex/Jd6bAYIGHk+whfcA5zhadRZJ2Y19Mbcms9kaLCk3QpO07WKwSMdx+Np82NX Up8zJ+yTsPG+9R8RyyxbGmh3r/yGeSZ97JZPmdHZcFMolbrn5YRzFKn7hVnxL1p3WoJA=; Received: from p54ae95e7.dip0.t-ipconnect.de ([84.174.149.231] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1seytF-000MlX-1v; Fri, 16 Aug 2024 17:29:21 +0200 Message-ID: <2bb2f7ae-1175-4fff-ae4e-25c624295345@nbd.name> Date: Fri, 16 Aug 2024 17:29:21 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] net: remove NETIF_F_GSO_FRAGLIST from NETIF_F_GSO_SOFTWARE To: Willem de Bruijn , netdev@vger.kernel.org References: <20240816075915.6245-1-nbd@nbd.name> <66bf5e76d36cf_1341d52942a@willemb.c.googlers.com.notmuch> From: Felix Fietkau Content-Language: en-US Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: <66bf5e76d36cf_1341d52942a@willemb.c.googlers.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.08.24 16:13, Willem de Bruijn wrote: > Felix Fietkau wrote: >> Several drivers set NETIF_F_GSO_SOFTWARE, but mangle fraglist GRO packets >> in a way that they can't be properly segmented anymore. > > Can you share a bit more concrete detail: which driver, for instance, and > how does it mangle the packet? > > I assume something with inserting or deleting tunnel headers. But the > fraglist skbs should be able to reproduce the modified header in > skb_segment_list? I've received bug reports from a variety of people, often with very little context, usually crashing while segmenting fraglist skbs. The ones that people were able to easily reproduce involved bridging with vxlan or virtio net devices. People using those two reported that my patch fixed their crashes. I will try to gather more information about the root cause of the crashes. - Felix