From: Daniel Borkmann <daniel@iogearbox.net>
To: Pu Lehui <pulehui@huaweicloud.com>,
bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
netdev@vger.kernel.org
Cc: "Björn Töpel" <bjorn@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Pu Lehui" <pulehui@huawei.com>
Subject: Re: [PATCH RESEND bpf-next v4 2/3] selftests/bpf: Factor out many args tests from tracing_struct
Date: Mon, 1 Jul 2024 18:12:31 +0200 [thread overview]
Message-ID: <2bbced4a-1022-aace-52b4-e0abe426347b@iogearbox.net> (raw)
In-Reply-To: <20240622022129.3844473-3-pulehui@huaweicloud.com>
On 6/22/24 4:21 AM, Pu Lehui wrote:
> From: Pu Lehui <pulehui@huawei.com>
>
> Factor out many args tests from tracing_struct and rename some function
> names to make more sense.
>
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
[...]
> diff --git a/tools/testing/selftests/bpf/progs/tracing_struct_many_args.c b/tools/testing/selftests/bpf/progs/tracing_struct_many_args.c
> new file mode 100644
> index 000000000000..8bd696dc81d9
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/tracing_struct_many_args.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (C) 2024. Huawei Technologies Co., Ltd */
Overall looks good and ready to land, one small request: lets drop the copyright
comment here since this commit is only moving the existing tests out to its own
file which have been added originally via 5e9cf77d81f9 ("selftests/bpf: add testcase
for TRACING with 6+ arguments").
Thanks,
Daniel
next prev parent reply other threads:[~2024-07-01 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 2:21 [PATCH RESEND bpf-next v4 0/3] Add 12-argument support for RV64 bpf trampoline Pu Lehui
2024-06-22 2:21 ` [PATCH RESEND bpf-next v4 1/3] riscv, bpf: " Pu Lehui
2024-06-22 2:21 ` [PATCH RESEND bpf-next v4 2/3] selftests/bpf: Factor out many args tests from tracing_struct Pu Lehui
2024-07-01 16:12 ` Daniel Borkmann [this message]
2024-07-02 1:24 ` Pu Lehui
2024-06-22 2:21 ` [PATCH RESEND bpf-next v4 3/3] selftests/bpf: Add testcase where 7th argment is struct Pu Lehui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bbced4a-1022-aace-52b4-e0abe426347b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=pulehui@huawei.com \
--cc=pulehui@huaweicloud.com \
--cc=puranjay@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).