From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S9skzAMD" Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82628C7 for ; Mon, 11 Dec 2023 14:55:43 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-28abd1ecb85so15793a91.0 for ; Mon, 11 Dec 2023 14:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702335343; x=1702940143; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CpCO8M8u7JTPy3NA5O/1bcwGhDv/cEsX9d26pg1wuvU=; b=S9skzAMDN2DoO2FusT9qT/UDDwRIzUv/mWl/eI4qHyvo/EdovOEz09rWbXKaR+clC0 /d3w8ulpl4Sp+U6FR8alWI8GkKfo1EsqVH2D4Z39qsOB6vQNgpRuFu1/zadIFS2eaGRZ vJzIRkLcdFMZ6U7GU2GMWDa0puRDTeC0PwAPPENaF0Grn6f51/6PGom9wpHcng9yEbTM XK1eKE4WBQIRtZs4NWkGrD5CD00Zb6W6nw78UvWEOzApL9MJ75qKTuPf9uU4xRmJpokp ygGZfp8O4PMsDrdiZVrtN35QTpj6HcmMsbHnSMo5Zv4wGpLAiDtQhiPPpl4UHgdYAswO xWsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702335343; x=1702940143; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CpCO8M8u7JTPy3NA5O/1bcwGhDv/cEsX9d26pg1wuvU=; b=aPMd2zusJGWOzuyTv8zHO1CLWPc0Be+5m2+fYxNsJ2XZVP/aio3hUt4Qd/2kWltmhB fctEkCLnuT6ne1YSQUXHl8aJ5e7QMZCEYzMOVNwNIaMr7extt6Zyi9b8p/LyMyLglC2B 4YyhsALPNnArqhx2Kx5fM6c/8+JQ55NbDWnf821V/VsFBq4pVIOwlP1b7hpg86INThfT Cp2oI/fosKFdThZA3RrdgDhHqNMQq3yHCXJvKnnKNzzZ/5yzQtrQgm/dm3YD8dt6ypqS Lj6FcS0K8DVWtydzXFd6q2WIJeJemFDQfYyayLGQPZNmNsIVz1D/IspKKUotIO5ldhgV oSMA== X-Gm-Message-State: AOJu0Yz1ldDxaTn2IQ+kXEjvrruLqcehePDjIU+iwA9shX3NsZcw29rI Y+UPbfKkBaT2w8a0LsmkWCE= X-Google-Smtp-Source: AGHT+IHVPMUQznw1/8pblBDzxSLVsYMCw8JciMtghrzjCPyuBudDwJ+t2BRtoKfCoyj1FKRDzNeGGw== X-Received: by 2002:a17:90b:b14:b0:286:c399:7c16 with SMTP id bf20-20020a17090b0b1400b00286c3997c16mr2404345pjb.44.1702335342921; Mon, 11 Dec 2023 14:55:42 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id qj12-20020a17090b28cc00b0028672a85808sm7594587pjb.35.2023.12.11.14.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 14:55:42 -0800 (PST) Message-ID: <2c05c48c-eb86-429b-8496-a06b37f851a2@gmail.com> Date: Mon, 11 Dec 2023 14:55:40 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 net-next 3/8] net: dsa: mv88e6xxx: Fix mv88e6352_serdes_get_stats error path Content-Language: en-US To: Tobias Waldekranz , davem@davemloft.net, kuba@kernel.org Cc: andrew@lunn.ch, olteanv@gmail.com, netdev@vger.kernel.org, Vladimir Oltean References: <20231211223346.2497157-1-tobias@waldekranz.com> <20231211223346.2497157-4-tobias@waldekranz.com> From: Florian Fainelli In-Reply-To: <20231211223346.2497157-4-tobias@waldekranz.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/11/23 14:33, Tobias Waldekranz wrote: > mv88e6xxx_get_stats, which collects stats from various sources, > expects all callees to return the number of stats read. If an error > occurs, 0 should be returned. > > Prevent future mishaps of this kind by updating the return type to > reflect this contract. > > Reviewed-by: Vladimir Oltean > Signed-off-by: Tobias Waldekranz Reviewed-by: Florian Fainelli -- Florian