From: Cosmin Ratiu <cratiu@nvidia.com>
To: "kuba@kernel.org" <kuba@kernel.org>,
"saeed@kernel.org" <saeed@kernel.org>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"hawk@kernel.org" <hawk@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Moshe Shemesh <moshe@nvidia.com>
Subject: Re: [PATCH net-next V2 07/11] net/mlx5e: SHAMPO: Headers page pool stats
Date: Fri, 6 Jun 2025 10:43:46 +0000 [thread overview]
Message-ID: <2c0dbde8d0e65678eeb0847db1710aaef3a8ce91.camel@nvidia.com> (raw)
In-Reply-To: <aC-sIWriYzWbQSxc@x130>
On Thu, 2025-05-22 at 15:58 -0700, Saeed Mahameed wrote:
> On 22 May 15:31, Jakub Kicinski wrote:
> > On Fri, 23 May 2025 00:41:22 +0300 Tariq Toukan wrote:
> > > Expose the stats of the new headers page pool.
> >
> > Nope. We have a netlink API for page pool stats.
> >
>
> We already expose the stats of the main pool in ethtool.
> So it will be an inconvenience to keep exposing half of the stats.
> So either we delete both or keep both. Some of us rely on this for
> debug
>
What is the conclusion here?
Do we keep this patch, to have all the stats in the same place?
Or do we remove it, and then half of the stats will be accessible
through both ethtool and netlink, and the other half only via netlink?
Cosmin.
next prev parent reply other threads:[~2025-06-06 10:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 21:41 [PATCH net-next V2 00/11] net/mlx5e: Add support for devmem and io_uring TCP zero-copy Tariq Toukan
2025-05-22 21:41 ` [PATCH net-next V2 01/11] net: Kconfig NET_DEVMEM selects GENERIC_ALLOCATOR Tariq Toukan
2025-05-22 23:07 ` Mina Almasry
2025-05-22 21:41 ` [PATCH net-next V2 02/11] net: Add skb_can_coalesce for netmem Tariq Toukan
2025-05-22 23:09 ` Mina Almasry
2025-05-25 13:03 ` Dragos Tatulea
2025-05-25 17:44 ` Mina Almasry
2025-05-28 9:13 ` Dragos Tatulea
2025-05-22 21:41 ` [PATCH net-next V2 03/11] net/mlx5e: SHAMPO: Reorganize mlx5_rq_shampo_alloc Tariq Toukan
2025-05-22 21:41 ` [PATCH net-next V2 04/11] net/mlx5e: SHAMPO: Remove redundant params Tariq Toukan
2025-05-22 21:41 ` [PATCH net-next V2 05/11] net/mlx5e: SHAMPO: Improve hw gro capability checking Tariq Toukan
2025-05-22 21:41 ` [PATCH net-next V2 06/11] net/mlx5e: SHAMPO: Separate pool for headers Tariq Toukan
2025-05-22 22:30 ` Jakub Kicinski
2025-05-22 23:08 ` Saeed Mahameed
2025-05-22 23:24 ` Mina Almasry
2025-05-22 23:43 ` Saeed Mahameed
2025-05-27 15:29 ` Jakub Kicinski
2025-05-27 15:53 ` Dragos Tatulea
2025-05-22 21:41 ` [PATCH net-next V2 07/11] net/mlx5e: SHAMPO: Headers page pool stats Tariq Toukan
2025-05-22 22:31 ` Jakub Kicinski
2025-05-22 22:58 ` Saeed Mahameed
2025-06-06 10:43 ` Cosmin Ratiu [this message]
2025-06-08 10:09 ` Tariq Toukan
2025-06-09 15:20 ` Jakub Kicinski
2025-05-22 21:41 ` [PATCH net-next V2 08/11] net/mlx5e: Convert over to netmem Tariq Toukan
2025-05-22 23:18 ` Mina Almasry
2025-05-22 23:54 ` Saeed Mahameed
2025-05-23 17:58 ` Mina Almasry
2025-05-23 19:22 ` Saeed Mahameed
2025-05-22 21:41 ` [PATCH net-next V2 09/11] net/mlx5e: Add support for UNREADABLE netmem page pools Tariq Toukan
2025-05-22 23:26 ` Mina Almasry
2025-05-22 23:56 ` Saeed Mahameed
2025-05-22 21:41 ` [PATCH net-next V2 10/11] net/mlx5e: Implement queue mgmt ops and single channel swap Tariq Toukan
2025-05-22 21:41 ` [PATCH net-next V2 11/11] net/mlx5e: Support ethtool tcp-data-split settings Tariq Toukan
2025-05-22 22:55 ` Jakub Kicinski
2025-05-22 23:19 ` Saeed Mahameed
2025-05-23 16:17 ` Cosmin Ratiu
2025-05-23 19:35 ` saeed
2025-05-27 16:10 ` Jakub Kicinski
2025-05-28 5:10 ` Gal Pressman
2025-05-29 0:12 ` Jakub Kicinski
2025-05-27 16:05 ` [PATCH net-next V2 00/11] net/mlx5e: Add support for devmem and io_uring TCP zero-copy Stanislav Fomichev
2025-05-28 9:17 ` Dragos Tatulea
2025-05-28 15:45 ` Stanislav Fomichev
2025-05-28 22:59 ` Mina Almasry
2025-05-28 23:04 ` Stanislav Fomichev
2025-05-29 11:11 ` Dragos Tatulea
2025-06-06 9:00 ` Cosmin Ratiu
2025-05-28 0:31 ` Jakub Kicinski
2025-05-28 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0dbde8d0e65678eeb0847db1710aaef3a8ce91.camel@nvidia.com \
--to=cratiu@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).