From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:54906 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbeCOVeO (ORCPT ); Thu, 15 Mar 2018 17:34:14 -0400 Received: by mail-wm0-f65.google.com with SMTP id h76so13139895wme.4 for ; Thu, 15 Mar 2018 14:34:13 -0700 (PDT) Subject: Re: [PATCH RFC 0/7] net: phy: patch series aiming to improve few aspects of phylib To: Florian Fainelli , Andrew Lunn Cc: Geert Uytterhoeven , "netdev@vger.kernel.org" References: <421476ed-03c7-63a0-44a4-c6d9c7702647@gmail.com> <90ec1e79-d5fd-2871-3b99-fcc8e51804d6@gmail.com> From: Heiner Kallweit Message-ID: <2c2e663b-a1c9-71ee-4dda-d8c8f7291951@gmail.com> Date: Thu, 15 Mar 2018 22:08:10 +0100 MIME-Version: 1.0 In-Reply-To: <90ec1e79-d5fd-2871-3b99-fcc8e51804d6@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: Am 15.03.2018 um 00:53 schrieb Florian Fainelli: > On 03/14/2018 01:10 PM, Heiner Kallweit wrote: >> This patch series aims to tackle few issues with phylib: >> >> - address issues with patch series [1] (smsc911x + phylib changes) >> - make phy_stop synchronous >> - get rid of phy_start/stop_machine and handle it in phy_start/phy_stop >> - in mdio_suspend consider runtime pm state of mdio bus parent >> - consider more WOL conditions when deciding whether PHY is allowed to >> suspend >> - only resume phy after system suspend if needed >> >> [1] https://www.mail-archive.com/netdev@vger.kernel.org/msg196061.html >> >> It works fine here but other NIC drivers may use phylib differently. >> Therefore I'd appreciate feedback and more testing. >> >> I could think of some subsequent patches, e.g. phy_error() could be >> reduced to calling phy_stop() and printing an error message >> (today it silently sets the PHY state to PHY_HALTED). > > Thanks for the patch series, I will give it a spin on a number of > devices using different PHYLIB integration and see if something breaks. > Great, and thanks for the immediate feedback. I'll prepare a v2 based on it, also considerung Geert's feedback. >> >> Heiner Kallweit (7): >> net: phy: unconditionally resume and re-enable interrupts in phy_start >> net: phy: improve checking for when PHY is allowed to suspend >> net: phy: resume PHY only if needed in mdio_bus_phy_suspend >> net: phy: remove phy_start_machine >> net: phy: make phy_stop synchronous >> net: phy: use new function phy_stop_suspending in mdio_bus_phy_suspend >> net: phy: remove phy_stop_machine >> >> drivers/net/phy/phy.c | 102 +++++++++++++++++-------------------------- >> drivers/net/phy/phy_device.c | 80 ++++++++++++++++++++------------- >> drivers/net/phy/phylink.c | 1 - >> include/linux/phy.h | 14 ++++-- >> 4 files changed, 100 insertions(+), 97 deletions(-) >> > >