From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anna Schumaker Subject: Re: [PATCH 1/3] net:svc_rdma_transport: remove unneeded variable 'ret' in rdma_listen_handler Date: Tue, 7 Aug 2018 10:49:11 -0400 Message-ID: <2c343d78-e668-1b97-a4e6-228296da0d70@Netapp.com> References: <1533640809-1221-1-git-send-email-zhongjiang@huawei.com> <1533640809-1221-2-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: , To: zhong jiang , , "J. Bruce Fields" Return-path: Received: from mx143.netapp.com ([216.240.21.24]:27936 "EHLO mx143.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732619AbeHGREK (ORCPT ); Tue, 7 Aug 2018 13:04:10 -0400 In-Reply-To: <1533640809-1221-2-git-send-email-zhongjiang@huawei.com> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: (Adding Bruce since he takes nfs / sunrpc server patches) On 08/07/2018 07:20 AM, zhong jiang wrote: > The ret is not modified after initalization, So just remove the variable > and return 0. > > Signed-off-by: zhong jiang > --- > net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c > index 547b2cd..2848caf 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c > @@ -296,7 +296,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > struct rdma_cm_event *event) > { > struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr; > - int ret = 0; > > trace_svcrdma_cm_event(event, sap); > > @@ -315,7 +314,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > break; > } > > - return ret; > + return 0; > } > > static int rdma_cma_handler(struct rdma_cm_id *cma_id, >