From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29B131E4A6 for ; Wed, 29 May 2024 01:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716945365; cv=none; b=CgmeC9QNFX/bT6FYWfaW9h7qXNleqrXIlTqwQqW/idx+otXnBCp25LHXJ7+ynWZRbPN4eW6mQ4Ad9ASOTrBEkAK4fJoF/JZBJjeZTKLV+LOT0bbHgoiolwdqtgItG5zvJp/2pivlffvdCdbx6mwPQ/ZPXz9ZTAKQKPLCTXPLVUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716945365; c=relaxed/simple; bh=VbXMKPFRNM4rvJJUONqIaV2ZyDimdXjJrsK52bXShYY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FlZSizhJffuNnAwAHd4TubUtAXCi3lsTvsjl2dn2ML2qO8UjZJ5N0ws8SuwE6QbbacwrWBfRoDDfGUQT+7bDUtLbQ8X6lpyaN7y1LhQXf04lXF1qdszw9xAmuyJCPBho95ZoLwT3x+NKw1kF7ZJf77tVLYcs1wUzTx6JsXSGh5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QyCmql2V; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QyCmql2V" X-Envelope-To: quic_abchauha@quicinc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716945360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zssiFsZDZZBTEpQvJYkG+CokD4QQQjIoL2kKugnyhxk=; b=QyCmql2V6OXKrZ5ZFlBeyb7JhYtjR5HEBKolnaVUPPakCu3U10iMi69Syi2uzvPpMvqQdu xFLJOQRaYAUoUs3/KycH3emfzXHatBCSXSetYR5/bBS/vKmy4qlT3tE1UHXWtajEsoPz0w sCKE3vb9kULn95vxftruVdj+vMYmDeI= X-Envelope-To: davem@davemloft.net X-Envelope-To: edumazet@google.com X-Envelope-To: kuba@kernel.org X-Envelope-To: pabeni@redhat.com X-Envelope-To: netdev@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: ahalaney@redhat.com X-Envelope-To: willemdebruijn.kernel@gmail.com X-Envelope-To: martin.lau@kernel.org X-Envelope-To: daniel@iogearbox.net X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: kernel@quicinc.com X-Envelope-To: syzbot+d7b227731ec589e7f4f0@syzkaller.appspotmail.com X-Envelope-To: syzbot+30a35a2e9c5067cc43fa@syzkaller.appspotmail.com Message-ID: <2c363f12-dd52-4163-bbcd-9a017cff6dd4@linux.dev> Date: Tue, 28 May 2024 18:15:51 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net] net: validate SO_TXTIME clockid coming from userspace To: Abhishek Chauhan Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , Willem de Bruijn , Martin KaFai Lau , Daniel Borkmann , bpf , kernel@quicinc.com, syzbot+d7b227731ec589e7f4f0@syzkaller.appspotmail.com, syzbot+30a35a2e9c5067cc43fa@syzkaller.appspotmail.com References: <20240528224935.1020828-1-quic_abchauha@quicinc.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20240528224935.1020828-1-quic_abchauha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 5/28/24 3:49 PM, Abhishek Chauhan wrote: > Currently there are no strict checks while setting SO_TXTIME > from userspace. With the recent development in skb->tstamp_type > clockid with unsupported clocks results in warn_on_once, which causes > unnecessary aborts in some systems which enables panic on warns. > > Add validation in setsockopt to support only CLOCK_REALTIME, > CLOCK_MONOTONIC and CLOCK_TAI to be set from userspace. > > Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/ > Link: https://lore.kernel.org/lkml/20240509211834.3235191-1-quic_abchauha@quicinc.com/ > Fixes: 1693c5db6ab8 ("net: Add additional bit to support clockid_t timestamp type") Patch lgtm. This should target for net-next instead of net. The Fixes patch is in net-next only. Acked-by: Martin KaFai Lau