From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] net: ipv6: prevent use after free in
 ip6_route_mpath_notify()
Date: Sun, 3 Jun 2018 19:39:59 -0700
Message-ID: <2c3bfeb5-1bca-f660-a93e-caec4deef325@gmail.com>
References: <20180603133546.28635-1-edumazet@google.com>
 <4b46d531-904b-6e5f-67ce-a275f0826d47@cumulusnetworks.com>
 <4dfbdd4b-947b-bbf7-27f3-abbd48a817b4@gmail.com>
 <26bd52c0-1218-3c65-95ca-b2a908466841@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev <netdev@vger.kernel.org>
To: David Ahern <dsa@cumulusnetworks.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:44547 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751479AbeFDCkB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 3 Jun 2018 22:40:01 -0400
Received: by mail-pg0-f67.google.com with SMTP id p21-v6so13777197pgd.11
        for <netdev@vger.kernel.org>; Sun, 03 Jun 2018 19:40:01 -0700 (PDT)
In-Reply-To: <26bd52c0-1218-3c65-95ca-b2a908466841@cumulusnetworks.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/03/2018 07:46 AM, David Ahern wrote:

> It was a mistake to set rt_last before checking err. So the
> use-after-free exposed the semantic error.
> 

SGTM, please send the formal patch then, thanks !