From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.226 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794957449; b=E5hol9xvoPURm8e01qPz2L4nvth08vJL9gpT8k+Cj4ni5FvjueaNdVv/XuKGZcW397XH YMcEXEDFImMeNJEV6ns/2ei8661m2YNLbcvvvQUQHBU52MFofkfG5js9uI5w9Z5m5uyyR 94kRhXuIpocAEcB3+vtzKOk7yKXTmwgbWftvT7Shtn7v2D01DORtllTDgOKBMUlABzjXn iYZ11r7on3QvLU4tUVT/ZDOvfv6SMR8GEvuVnkMoW//mMT30RFtZyfvDKFpNCCEcRES+y DuR7CuJjsRQ7LnfZyV1kR7N9IgrKKM+t7wPqUblYxQClZ00UsS5Gxah5Qsrhq3wCsPw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794957449; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Gm-Message-State: X-Gm-Gg:X-Received:Received:X-Relaying-Domain:X-CFilter-Loop:Received: DKIM-Signature:X-Received:X-Received:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:Autocrypt:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-DetectorID-Processed; bh=YN42KLvyZcy91IWqxlUOxZHph6z3eUCBXtgG5cXNtsc=; b=j3zfQdJrvFCkutUg8Q03NP+WYlKirruBaIq4eaYvKs1y2dz1kc3X9INDCsPKDHFalgOu HwSfKu7bamCObsCaBO9TmV5LbJJ6BDYuSmaj4FECiYP4FNxODd2KDve9JPbje7YIAeYy4 +ma+KqYFtYl3mcFmPtYdU76yskyK4M3VFau7nmZk0ag44sNhU1m6yU9IUlaGrg9npfJuS 5ZzaPZDQ2g82o77PrMeMgtpPECFyYNM0JpcAbzjcFNtbkK5PRMe8vyaH/G6IVVmdG4KD4 ULXocprAeQeK2lMKYrCZukqHmh7pgYBkLgccubzbYb2SmeVrl3l10zjRswbzm8HfUfQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b="cHSe/7PF"; arc=none smtp.remote-ip=74.125.82.226 Received: from mail-dy1-f226.google.com (mail-dy1-f226.google.com [74.125.82.226]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D9D0606A330 for ; Tue, 17 Nov 2026 23:17:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3D9D0606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=cHSe/7PF Received: by mail-dy1-f226.google.com with SMTP id 5a478bee46e88-3282db206d3so1025234eec.0 for ; Tue, 17 Nov 2026 15:17:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794957448; x=1795562248; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=YN42KLvyZcy91IWqxlUOxZHph6z3eUCBXtgG5cXNtsc=; b=N074mxkYGfHg+C105REGQXh03Fligni2MDOPiol39low7hkFnSrzHiT/zUk+GsrAOs ZzIe4Gv4Hcxpsg0yWuk1g+XIwx61dJ/fXFJEbs2N/CZeoBzc+42bPMgGsJ8zCoiwgw0G xi1SZOl2VLKobyS/GLEFuSKNEwSEa4h3zsHP5l/Sf5XOfWbAah5gL7pDFdpI8BpgJdK/ JV1fzcPW1ucCG9R644ZBeA5N8TY96vz7M72mS9dtMK3CmIaVPaTQmXerzW8j6PPrAvAP /amvg2/I3b7TtKLMjGFkwG34/9Rx3hTAoSM9AKisNVjJoU2fMfyT4rRd4Mt1gKVmlY9a 3FAA== X-Gm-Message-State: APuU4Z/xa18JV/E0GAoaO+7lKP9AALMGXP2wQmyigIKjjQDqnrAXA3T/ lsIoS0ocY7O9gZ2+jyLxrtzj6+3E7Yx2cadMf1EY5S0g+lUtPlFTZLM1eaKNcfGK9eCP8h6Iamd 2F+dd8edpE5YbVZ0jvGkNSh2n50aABvNdgTgLkoKkBeir147gXstmTDNVSR7mM1Lsf1mS26lRmu 3lRvu4QUAio7lYiZjeZMPPSiYv8UEtwlMhvnSPhdo1uEeeP8h9aP36TC6PMCGf+vdVes16OleFg sfDwZMs+GXVy0Ya X-Gm-Gg: AZFdTZfgDoidX01GnFn3M89lMnW3e9fvZfQLwqwK7GgcaUd4nwQ4VzQI8sXKbuFEVh4 7z3licmRgZPAy4twdThfLmWXSGWb7jHV0ZcJ9LGqvxec0zMw+NGdAy/G/SXtLjmq7F0jDBHZ53c aYilKYsxVds6J1nXclgZsLwyQAialJn/sZbz4ZRUCpplxRsiXH/RjQX1c31B8QpZyHh0kbCGAHU KkBTjjapTrDM/zWDBSl6IZYIsY38JTPPmgMRDaqUR6hj6bQJyxA6QmGA7dXvEPIwP54UXMY6Ib0 Y/FNxRombH+OG6vk+u4O3L7M/k4vHMr8L3IYG3HLCIc0UBs3P86UU34O6cZYZrL11Bxo1Hr9ko7 v0K1q+PNXZnE5YNnzZZXNRYBwoA4h9XrOdgSWK/PG8wReeILlgFQRvR4ZoW3ERiy8XdgBf3z7wt uLjBVgPS1TCT4N2fgahKEyTvHxg313nHfN78TWrPH2dOA= X-Received: by 2002:a05:7300:bc03:b0:369:fc93:eda5 with SMTP id 5a478bee46e88-38281427c34mr1141394eec.39.1794957447928; Tue, 17 Nov 2026 15:17:27 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-123.dlp.protect.broadcom.com. [144.49.247.123]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-382a80b97f7sm12910eec.27.2026.11.17.15.17.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2026 15:17:27 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93f2373e9b4so55710685a.1 for ; Tue, 17 Nov 2026 15:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1794957446; x=1795562246; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YN42KLvyZcy91IWqxlUOxZHph6z3eUCBXtgG5cXNtsc=; b=cHSe/7PFvOnSeJuJJ5QZxyWK1Geu0R6QfU5sKTIJlv0pUIJ3BQHrZ5g7z0jucQNdGJ HvGFkv0x674WSpSahUolmXBX19n2fzkTo9Jyhk1w5TNUQyYco7J/JVEZUmfvoS/gj005 o2tm922srLsBrVBM0ocR8zZwoizJkWv+YuVyU= X-Received: by 2002:a05:620a:6402:b0:949:3521:b627 with SMTP id af79cd13be357-949995d0479mr197203785a.38.1794957446404; Tue, 17 Nov 2026 15:17:26 -0800 (PST) X-Received: by 2002:a05:620a:6402:b0:949:3521:b627 with SMTP id af79cd13be357-949995d0479mr197199385a.38.1794957445804; Tue, 17 Nov 2026 15:17:25 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9499b72055bsm41007085a.12.2026.11.17.15.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2026 15:17:25 -0800 (PST) Message-ID: <2c3c20ae-5866-463a-9bff-607c38b16a8f@broadcom.com> Date: Tue, 17 Nov 2026 15:17:22 -0800 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac To: netdev@vger.kernel.org Cc: Doug Berger , Nicolai Buchwitz , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , open list , Mlody12 mlody12 References: <20261116213449.1682731-1-florian.fainelli@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20261116213449.1682731-1-florian.fainelli@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 11/16/26 13:34, Florian Fainelli wrote: > This patch series adds support for Clause 45 MDIO operations within the > mdio-bcm-unimac driver. The series breaks things up in this way: > > - make the C45 bus scan done by the MDIO core carry on when nothing > answers at an address, as the C22 scan already does > - scope the existing defines to make it clear what is C22 vs. C45 > specific > - rework the polling completion loop to be a tighter loop > - add support for clause 45 operations > > Changes in v2: > > - add patch 1, since providing read_c45/write_c45 makes the MDIO core scan > for C45 PHYs on all addresses that are not masked. On a bus registered > without a device tree node (e.g.: GENET with ACPI) a read from an empty > address fails with -EIO, which get_phy_c45_ids() passed up instead of > mapping it to -ENODEV, and made the whole bus registration fail. Reported > by Nicolai Buchwitz. > - patches 2 and 3: collect Reviewed-by tags from Andrew Lunn and Nicolai > Buchwitz, no code changes > - patch 4: no code changes > > Florian Fainelli (4): > net: phy: Map C45 probe read errors to -ENODEV during bus scan > net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT > net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity > net: mdio: mdio-bcm-unimac: Add Clause 45 support > > drivers/net/mdio/mdio-bcm-unimac.c | 130 +++++++++++++++++++++++++---- > drivers/net/phy/phy_device.c | 24 ++++-- > 2 files changed, 134 insertions(+), 20 deletions(-) > Sashiko pointed some valid issues commenting on v1, and has not reviewed v2 yet which does not incorporate all of the feedback. There will be a v3 submitted that incorporates the received feedback. pw-bot: cr -- Florian