From: Paolo Abeni <pabeni@redhat.com>
To: Shinas Rasheed <srasheed@marvell.com>, horms@kernel.org
Cc: aayarekar@marvell.com, davem@davemloft.net, edumazet@google.com,
egallen@redhat.com, hgani@marvell.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, mschmidt@redhat.com,
netdev@vger.kernel.org, sburla@marvell.com, sedara@marvell.com,
vburru@marvell.com, vimleshk@marvell.com
Subject: Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG
Date: Tue, 12 Sep 2023 10:45:21 +0200 [thread overview]
Message-ID: <2c532d4594ca0cacdc0cfc5d1f5d55d5d758dc1b.camel@redhat.com> (raw)
In-Reply-To: <20230912070400.2136431-1-srasheed@marvell.com>
On Tue, 2023-09-12 at 00:04 -0700, Shinas Rasheed wrote:
> This change is required in octep_iq_process_completions, as given in the patch,
> since the scatter gather pointer lengths arrive as big-endian in hardware.
I guess Simon intended asking about octep_iq_free_pending(), and AFAICT
your reply confirm that the change is required there, too.
Additionally the changelog really need to be expanded. I don't
understand how this change relates to endianess: if the ring format is
big endian I expect some be16_to_cpu(len) instead of complement-to-4 of
indexes.
Please clarify and expand the changelog, thanks!
Paolo
next prev parent reply other threads:[~2023-09-12 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 9:23 [net PATCH] octeon_ep: fix tx dma unmap len values in SG Shinas Rasheed
2023-09-11 18:01 ` Simon Horman
2023-09-12 7:04 ` Shinas Rasheed
2023-09-12 8:45 ` Paolo Abeni [this message]
2023-09-13 5:49 ` [EXT] " Shinas Rasheed
2023-09-13 8:41 ` [net PATCH v2] " Shinas Rasheed
2023-09-14 10:57 ` Simon Horman
2023-09-15 13:00 ` patchwork-bot+netdevbpf
[not found] ` <PH0PR18MB473404EA35ADAC222C9EB68FC7F1A@PH0PR18MB4734.namprd18.prod.outlook.com>
2023-09-12 19:45 ` [EXT] Re: [net PATCH] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c532d4594ca0cacdc0cfc5d1f5d55d5d758dc1b.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=aayarekar@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).