From: Jason Wang <jasowang@redhat.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
davem@davemloft.net, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v3 2/5] virtio-net: transmit napi
Date: Tue, 25 Apr 2017 16:36:57 +0800 [thread overview]
Message-ID: <2c5491c0-4473-75d1-fa0f-a0dbd4dc626d@redhat.com> (raw)
In-Reply-To: <20170424174930.82623-3-willemdebruijn.kernel@gmail.com>
On 2017年04月25日 01:49, Willem de Bruijn wrote:
> @@ -1371,8 +1419,10 @@ static int virtnet_close(struct net_device *dev)
> /* Make sure refill_work doesn't re-enable napi! */
> cancel_delayed_work_sync(&vi->refill);
>
> - for (i = 0; i < vi->max_queue_pairs; i++)
> + for (i = 0; i < vi->max_queue_pairs; i++) {
> napi_disable(&vi->rq[i].napi);
> + napi_disable(&vi->sq[i].napi);
> + }
Looks like this will wait for ever if napi_tx is false because we never
enable the NAPI so we will wait for NAPI_STATE_SCHED to be cleared.
Thanks
next prev parent reply other threads:[~2017-04-25 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 17:49 [PATCH net-next v3 0/5] virtio-net tx napi Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 1/5] virtio-net: napi helper functions Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 2/5] virtio-net: transmit napi Willem de Bruijn
2017-04-25 8:36 ` Jason Wang [this message]
2017-04-25 14:32 ` Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 3/5] virtio-net: move free_old_xmit_skbs Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 4/5] virtio-net: clean tx descriptors from rx napi Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 5/5] virtio-net: keep tx interrupts disabled unless kick Willem de Bruijn
2021-04-13 5:06 ` Michael S. Tsirkin
2021-04-13 14:27 ` Willem de Bruijn
2021-04-13 19:34 ` Michael S. Tsirkin
2017-04-24 23:35 ` [PATCH net-next v3 0/5] virtio-net tx napi Michael S. Tsirkin
2017-04-25 13:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c5491c0-4473-75d1-fa0f-a0dbd4dc626d@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).