From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA70C43381 for ; Tue, 26 Mar 2019 13:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B98952070B for ; Tue, 26 Mar 2019 13:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jI8wKhWA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731475AbfCZNCV (ORCPT ); Tue, 26 Mar 2019 09:02:21 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:42426 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbfCZNCV (ORCPT ); Tue, 26 Mar 2019 09:02:21 -0400 Received: by mail-oi1-f196.google.com with SMTP id w139so9800710oie.9 for ; Tue, 26 Mar 2019 06:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7ZqOmdFdwZ/8lvqAei5Gk8SkQzsdaYHJEYfK2KPox1o=; b=jI8wKhWAj31yeLP02jv5VhmNtMGAiu9cCTlXIVMM8Av4rKBX7DTIJ/1Y2GXA/lcIFK o3JBddslyFgzCksVjxYpYY4ZnLmHZstYIoEQE86Wg9y1Cm7b/JN2BvLXsF/ctUFvt2cG COSxocA+0NA5vd1nPp59A8YCBd0fYa9imgni6tGVeAogYBqpy+Agqs5vim+VFxRdW5tt wPHnaRuCWYS7W/DgZJ5gO5f9mL4bppEcpa9oOjrjiNdWsWDbsZzP3Cp64YddF6DKe2V6 RLHvnX9riXQWQEsh1Dlh1ZO2WK6vFUmmb6gCt1Oq4xrGBR3w1RWG3dY3iSuteDs/f/qo Q39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7ZqOmdFdwZ/8lvqAei5Gk8SkQzsdaYHJEYfK2KPox1o=; b=BhbiFvaKLf1NmCFCuxQcLWWo3lWJ8U5KEatMRPKeep7z/PCA+/5VfV3F9zKY1bCLu3 +wSv7ph+KO5mUhtR2oMt72SIcc1bSS0KP1lXrNAGQSs5gRrvwkqjTMci/xh7gy20y4O/ cAmG/m3wCLCG78asplijMMuNnbXrWGksiQLgR4U4L6vUGXU0mJ3JCnimbQedUeGMJI3l ugfjytA7k30Ll4+7LnR8cYgsGLw5h+nZQ+1rbLLeYZb4bWAunkDtE6mIokc5tectQyNg rg1xUmFKBSQosfCioijrlnWBuf+1GbbD06KeHqJ2B9LmS5X+HYVjoxdIwJ79NmRgrm0t JyXQ== X-Gm-Message-State: APjAAAVB6HGUsBiFGpvMb5g7QDtghiKyTVQFTEEKJEoqH4QzHpkYwcMR 1n/XVhss+WQkR/rChG5Kubk= X-Google-Smtp-Source: APXvYqy+exJ39TIvXdgifqp0KuOKngM5HvkgDwnxURU57aP0f/1cr91vJVueND2qDy4IhAIvY9DdsA== X-Received: by 2002:aca:efc6:: with SMTP id n189mr11441955oih.34.1553605340108; Tue, 26 Mar 2019 06:02:20 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id 92sm7496505oti.60.2019.03.26.06.02.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 06:02:19 -0700 (PDT) Subject: Re: [RFC PATCH net-next 06/13] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch To: Vladimir Oltean , davem@davemloft.net, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, linus.walleij@linaro.org, Georg Waibel References: <20190324032346.32394-1-olteanv@gmail.com> <20190324032346.32394-7-olteanv@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <2c90604e-2e3c-55da-6702-3759da7dc4d7@gmail.com> Date: Tue, 26 Mar 2019 06:02:06 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190324032346.32394-7-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > At this moment the following is supported: > * Link state management through phylib Not a show stopper for now, and your implementation looks sane, though I would recommend implementing phylink to be future proof, and especially since you support SGMII. I was not able to review everything deeply so: Acked-by: Florian Fainelli -- Florian