From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9178D2DECC2 for ; Tue, 16 Jun 2026 09:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781603433; cv=none; b=S3lDzZfkN8a2OI5lBJQ7/7nliIQLamCVMgXml7JZBcd7G/HD6w7/R14TSXeVkV8JvG3A8aLIXAnPh7L9k428Mko8nlI7baXtC4qtbuC3HyUw098rLNNDVh+uRUQoEd5ogEypW45MBU66/y/J/M32bCWeu53wPUJgpUR8YMxwKes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781603433; c=relaxed/simple; bh=eoMATAuaff4rpJuBp0jfLJflfpP07L2+HWCSQU/Or9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E7dy/6zdRlWNMOOk44VeqfPLNlKaQQuzRsqEk8KRwRjLP6EaGMSGNORR0SKG8ZZ6XI4T4KFK83Rwr5QFihcZbnGapU8gzJRx3RpEYIKUHpLJk8ts/eRhVY7qerJ3ut7ThrYxnI6IYHQH15CoHA5tWSgta4hG5RN0lcRT2ZX1xoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CbxBq71T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WKOMD2Bm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CbxBq71T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WKOMD2Bm" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65G6fZGu2901610 for ; Tue, 16 Jun 2026 09:50:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NQiZZvuAbKBvUjZbZVVninjgYcEiugRsy2ygB3ZkJGs=; b=CbxBq71TeX+Ekoak Lr+ynkoEdj1zcqidsrSn38QeNLWeGOhqyeLtPPjgMaB2R7oPqTHWJYcZLW3g5Zrf Bezo7TbiQ7gA9HopG3BD240GOrzcfZuqT7DI3buVjY4QRP2BlezHoorSJZGSwR3q luNynNWBCKe/zxxZdDg4E50cctV5BU4udfdG54GgR60x1tI/vy8vTLAhRhpsnDL7 XyZKFran3CkRogVc2cBZCFg5MEg5EfU1ARnuWUXtYhB9RtlvBaZPRCJ/s3EAeSLn LM+xmccP7Nq+UCBdD83Am2bCRq2EKl7LAf6Gm/zYP7nL07hfelo0epnkHJrUrRIy +228jA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu1ep8s1t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 09:50:31 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9160006de85so115721785a.2 for ; Tue, 16 Jun 2026 02:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781603431; x=1782208231; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NQiZZvuAbKBvUjZbZVVninjgYcEiugRsy2ygB3ZkJGs=; b=WKOMD2BmWDmjOJeAwZQC/XfARCm9ugAHfFDp/Zsf6KooblxTg3EXb5cipNZ6G7B3+Q k7/eAmwddxf6DiKp7V5bhbLrc6/ZDz10uP6tCPyCT77uI4sGyk/9gH8u1LF8MUMnidX5 QhIIsuV2fRI5SS+R1YLREQYa2xCiT3Xc7DlVTtYIDBE297ac2WlpNHXgHc+2Ld3XHRjk hEaPHXjaJ7/gNXWa5J9lJWD89uuFCGcLiXYb+IIFd8YubX8NfNCioUY8t2QTEryS/WwR yAfbqmytgsH45yz+58t7/mTT6zt7t2Qd3xXFjuQCcA0ujae1r2v/Imiqn2Mld0Xx23+F v8dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781603431; x=1782208231; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NQiZZvuAbKBvUjZbZVVninjgYcEiugRsy2ygB3ZkJGs=; b=YhdJb5ckv+npKe+AYKiO3gcKXdHQZFZWjKVPhOcH1Ug7rSC27JeMdp/+QTajB7c1hM ZWH6rdhxjfiFGTQ5i/EEUo4RsZK2fNy2g5yzYhmAOyHA/ACMlLzrLec+XhtKCSM8DIzh l80wZBSD5d4GlwOcxXRSuuDLVIQbZoT47g2mpD1vFBVwEoauj7ldBlKavotKETCx8/SI TR/rLXTUnufPYeeUQxFiGjl/G5G+KNooMnsNIdno6O97v3HzngEXynLpEFyR2ShX/DKr Saiw6qsyAwZaka/SdX0wsLfL7mgHmE68d8/ll0vDx38zqOusex06FptL+dsLvys8Hywl 6BAw== X-Forwarded-Encrypted: i=1; AFNElJ9k10zjNtPrFngEvuf0W3LIsI1hTcDuOwEdEpQC3PVhs45kR5a4LJnnhQur2zaQ3DkkHzONL7s=@vger.kernel.org X-Gm-Message-State: AOJu0YwO5hpWlboXvqzx8+g+QS3sRZHkKNVG/06SUkUBzCp7VGwcNT+K ATigmt3nE+TzOYU4JyXuH5VwSSATCQDefLlYjdnKHNiA/1ySbSgewamLmRR+DQ7vSuwncRG+eG3 bKp9Qi/Pz9WshHdndgK4lznyDefWy1+gPrXlfRPSs7fQMlEVI0jkxx79tH0E= X-Gm-Gg: Acq92OFysCIjBGbAXkWP+K9xkRITz4JJWTslOHJfE3QEX9h0BZYallFw27a+pGNAdTn gPg28PWclYJvObV189Lpuvlq+GpeqzBIR67AdSfb6hOHxicxGKoJIF1uLfrkCn/Iw2OiXdJa3uF ZmCfwF+O5iQz44HVKkaPcKLzdRBcFkKSO01gdaB+noKy5FIrtPNxN8yr/O5fve2qg0tYmhhSpG+ o1/VsReMsSUG9eoiMJMOAomoLlSM2ho76uarOqi91S2bRVp02gnC9H8i8vx1zlCnqQnuCV19hwR jeTuLp/H3ElIf4CTTLCU8yHFuQtWa8TTXEP3SxebUKuKEeU1onyGOe2KbPV1TvCmH6AIfn+/pPZ o035cskF5QkE97ArLIiIWji40OsTkls5LbznFrrwJnEEX8Q== X-Received: by 2002:a05:620a:710c:b0:915:7a64:cb68 with SMTP id af79cd13be357-9161ba94318mr1786717685a.2.1781603430944; Tue, 16 Jun 2026 02:50:30 -0700 (PDT) X-Received: by 2002:a05:620a:710c:b0:915:7a64:cb68 with SMTP id af79cd13be357-9161ba94318mr1786714885a.2.1781603430509; Tue, 16 Jun 2026 02:50:30 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb4b22136sm630904566b.15.2026.06.16.02.50.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:50:29 -0700 (PDT) Message-ID: <2cb658f3-f564-4396-884d-d025eaa674a1@oss.qualcomm.com> Date: Tue, 16 Jun 2026 11:50:26 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 8/9] arm64: dts: qcom: shikra-cqs-evk: Enable ethernet0 To: Mohd Ayaan Anwar , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Maxime Coquelin , Alexandre Torgue , Russell King Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20260612-shikra_ethernet-v1-0-f0f4a1d19929@oss.qualcomm.com> <20260612-shikra_ethernet-v1-8-f0f4a1d19929@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260612-shikra_ethernet-v1-8-f0f4a1d19929@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I/ZVgtgg c=1 sm=1 tr=0 ts=6a311c67 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=w1iEB-1klUxI70mDNfQA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDA5OSBTYWx0ZWRfX1KsBttHKMl5R X0a6glVPxSiLKHL8vvYXQ/k6LA6UMo1STkhVAIYbTRj2qHezzRjfSdnxjoDu6REUsd1Ls2z2vmA 4sglHcrBCx+u0Zp5kB7r+ceAJuM/rjk= X-Proofpoint-ORIG-GUID: jpDP0Hl0_jnpXR03txZ-SVFzdm0af1JJ X-Proofpoint-GUID: jpDP0Hl0_jnpXR03txZ-SVFzdm0af1JJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDA5OSBTYWx0ZWRfX53qfUUvXfKat wrKnpGMkW4BiF55ypjmhHLOVcyC9QZBRcDJQTj9jVUujPt7Mxjxw9buO7R8mb2J6JNb+1xOqSCT 7EHpxQZLEpWMCyNGTgQm4zveexQOEN0wXnB0Cb20fAn/zQD6fizRD9JjUC411zhldz9b9JwcOnf l+OVZZkbed6f5E1KIqJsqwFOmhzUA76PzqbxBc+IRhmvAX1RGhB2R9xwIu8/ipf145/tnM3TeFT u7rHa7JwIDuUVxvQRchWTKgbvzfSnKBBHi23Wl6+5gbH8gWgVKPxIFIgxPaCGz3+/DWyzr9RjpI u7UhcS5kdybhkrz4uzSFdaSE8S5o/jpfXwKePcS4r2oLFBFL0TmH7ktE9GTR+usOADTks+zBHxR Pf2jQGho3Zewu48P6RjcYBh85ywKJho/eTYc/SkptvUP9l9s7yLRcLtSXsInuJqkN1n6cvrcXdP xThGrye1yMsH3MkUZFw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_02,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160099 On 6/11/26 8:37 PM, Mohd Ayaan Anwar wrote: > Enable the first Gigabit Ethernet controller. The board layout is > identical to the CQM EVK. > > Signed-off-by: Mohd Ayaan Anwar > --- > arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 119 ++++++++++++++++++++++++++++ > 1 file changed, 119 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > index 26ff8007a819e46bbc9ffa3dddc6fee6530a4a7a..1f2e4f6dd7cca436f62ba9f09cd328e5a2079095 100644 > --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > @@ -7,6 +7,7 @@ > > #include "shikra-cqm-som.dtsi" > #include "shikra-evk.dtsi" > +#include > > / { > model = "Qualcomm Technologies, Inc. Shikra CQS EVK"; > @@ -60,6 +61,92 @@ vreg_pmu_ch1: ldo4 { > }; > }; > > +ðernet0 { > + status = "okay"; 'status' should go last, with a \n before it > + phy-handle = <ðphy0>; > + phy-mode = "rgmii-id"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet0_defaults>; property-n property-names in this order, please [...] > +&tlmm { > + ethernet0_defaults: ethernet0-defaults-state { s/defaults/default Please move this definition to shikra.dtsi > + rgmii-rx-pins { > + pins = "gpio121", "gpio122", "gpio123", > + "gpio124", "gpio125", "gpio126"; > + function = "rgmii"; > + bias-disable; > + drive-strength = <16>; Let's move drive-strength before bias (that's the order used in other places) > + }; > + rgmii-tx-pins { Please separate subsequent subnodes with \n > + pins = "gpio127", "gpio128", "gpio129", > + "gpio130", "gpio131", "gpio132"; > + function = "rgmii"; > + bias-pull-up; > + drive-strength = <16>; > + }; > + rgmii-mdio-pins { > + pins = "gpio133", "gpio134"; > + function = "rgmii"; > + bias-pull-up; > + drive-strength = <16>; > + }; > + }; > + > + emac0_phy_en_hog: emac0-phy-en-hog { > + gpio-hog; > + gpios = <149 GPIO_ACTIVE_HIGH>; > + output-high; > + line-name = "emac0-phy-en"; > + }; This looks like a hack - what does this pin actually do? Konrad