From: Andreas Roeseler <andreas.a.roeseler@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org
Subject: Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages
Date: Wed, 24 Mar 2021 15:24:51 -0500 [thread overview]
Message-ID: <2cbb962675f646454f19e08e3c86e1b8ff09300c.camel@gmail.com> (raw)
In-Reply-To: <ce5b1c2f-1b88-d4c8-2afd-867db9092606@gmail.com>
On Wed, 2021-03-24 at 20:47 +0100, Eric Dumazet wrote:
>
>
> On 3/24/21 7:18 PM, Andreas Roeseler wrote:
> > Modify the icmp_rcv function to check PROBE messages and call
> > icmp_echo
> > if a PROBE request is detected.
> >
>
>
> ...
>
> > @@ -1340,6 +1440,7 @@ static int __net_init icmp_sk_init(struct net
> > *net)
> >
> > /* Control parameters for ECHO replies. */
> > net->ipv4.sysctl_icmp_echo_ignore_all = 0;
> > + net->ipv4.sysctl_icmp_echo_enable_probe = 0;
> > net->ipv4.sysctl_icmp_echo_ignore_broadcasts = 1;
> >
> > /* Control parameter - ignore bogus broadcast responses? */
> >
>
> Where is sysctl_icmp_echo_enable_probe defined ?
It is defined in patch 3 of this patchset.
>
> Please include a cover letter, also add proper documentation for any
> new sysctl
> in Documentation/networking/ip-sysctl.rst
>
Will do.
next prev parent reply other threads:[~2021-03-24 20:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 18:17 [PATCH net-next V5 0/6] add support for RFC 8335 PROBE Andreas Roeseler
2021-03-24 18:17 ` [PATCH net-next V5 1/6] icmp: " Andreas Roeseler
2021-03-24 18:17 ` [PATCH net-next V5 2/6] ICMPV6: " Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 3/6] net: add sysctl for enabling RFC 8335 PROBE messages Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 4/6] net: add support for sending " Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 5/6] ipv6: add ipv6_dev_find to stubs Andreas Roeseler
2021-03-24 18:18 ` [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages Andreas Roeseler
2021-03-24 19:47 ` Eric Dumazet
2021-03-24 20:24 ` Andreas Roeseler [this message]
2021-03-28 17:00 ` Willem de Bruijn
2021-03-29 18:33 ` Andreas Roeseler
2021-03-29 18:42 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cbb962675f646454f19e08e3c86e1b8ff09300c.camel@gmail.com \
--to=andreas.a.roeseler@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).