* [PATCH net v3] net: lan966x: fix parameter check in two functions
@ 2023-07-14 8:51 Minjie Du
2023-07-14 9:12 ` Markus Elfring
2023-07-15 9:34 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Minjie Du @ 2023-07-14 8:51 UTC (permalink / raw)
To: Horatiu Vultur, maintainer:MICROCHIP LAN966X ETHERNET DRIVER,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, open list:MICROCHIP LAN966X ETHERNET DRIVER,
open list
Cc: opensource.kernel, Minjie Du
Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return.
in lan966x_ptp_add_trap() and lan966x_ptp_del_trap().
Fixes: 72df3489fb10 ("net: lan966x: Add ptp trap rules")
Signed-off-by: Minjie Du <duminjie@vivo.com>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
V2 -> V3: set the target tree in the subject and add 'Reviewed-by:' tag.
V1 -> V2: add Fixes tag.
V1: fix parameter check in two functions.
---
drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c b/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
index 266a21a2d..59dd14247 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
@@ -59,7 +59,7 @@ static int lan966x_ptp_add_trap(struct lan966x_port *port,
int err;
vrule = vcap_get_rule(lan966x->vcap_ctrl, rule_id);
- if (vrule) {
+ if (!IS_ERR_OR_NULL(vrule)) {
u32 value, mask;
/* Just modify the ingress port mask and exit */
@@ -106,7 +106,7 @@ static int lan966x_ptp_del_trap(struct lan966x_port *port,
int err;
vrule = vcap_get_rule(lan966x->vcap_ctrl, rule_id);
- if (!vrule)
+ if (IS_ERR_OR_NULL(vrule))
return -EEXIST;
vcap_rule_get_key_u32(vrule, VCAP_KF_IF_IGR_PORT_MASK, &value, &mask);
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v3] net: lan966x: fix parameter check in two functions
2023-07-14 8:51 [PATCH net v3] net: lan966x: fix parameter check in two functions Minjie Du
@ 2023-07-14 9:12 ` Markus Elfring
2023-07-15 9:34 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2023-07-14 9:12 UTC (permalink / raw)
To: Minjie Du, opensource.kernel, netdev, kernel-janitors,
UNGLinuxDriver, David S. Miller, Eric Dumazet, Horatiu Vultur,
Jakub Kicinski, Paolo Abeni, Richard Cochran
Cc: LKML, Wang Ming
> Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return.
> in lan966x_ptp_add_trap() and lan966x_ptp_del_trap().
Will interests grow for another improved change description?
…
> ---
> V2 -> V3: set the target tree in the subject and add 'Reviewed-by:' tag.
> V1 -> V2: add Fixes tag.
> V1: fix parameter check in two functions.
> ---
> drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c | 4 ++--
…
I suggest once more to replace the second marker by a line break.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n711
Would a subject like “[PATCH net v4] net: lan966x: Fix an error check in two functions”
be more appropriate?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v3] net: lan966x: fix parameter check in two functions
2023-07-14 8:51 [PATCH net v3] net: lan966x: fix parameter check in two functions Minjie Du
2023-07-14 9:12 ` Markus Elfring
@ 2023-07-15 9:34 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-07-15 9:34 UTC (permalink / raw)
To: Minjie Du
Cc: Horatiu Vultur, maintainer:MICROCHIP LAN966X ETHERNET DRIVER,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, open list:MICROCHIP LAN966X ETHERNET DRIVER,
open list, opensource.kernel
On Fri, Jul 14, 2023 at 04:51:15PM +0800, Minjie Du wrote:
> Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return.
> in lan966x_ptp_add_trap() and lan966x_ptp_del_trap().
>
> Fixes: 72df3489fb10 ("net: lan966x: Add ptp trap rules")
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-15 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14 8:51 [PATCH net v3] net: lan966x: fix parameter check in two functions Minjie Du
2023-07-14 9:12 ` Markus Elfring
2023-07-15 9:34 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).