netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] net: sched: put back q.qlen into a single location
Date: Fri, 08 Mar 2019 12:01:41 +0100	[thread overview]
Message-ID: <2ccbbbc1393e55ee8a199b1bdd0e36087fa6d71d.camel@redhat.com> (raw)
In-Reply-To: <20190228205543.172713-1-edumazet@google.com>

Hi,

Thank you for fixing this!

On Thu, 2019-02-28 at 12:55 -0800, Eric Dumazet wrote:
> Later (net-next) we might revert this patch by tracking all these
> qlen uses and replace them by a more efficient method (not having
> to access a precise qlen, but an empty/non_empty status that might
> be less expensive to maintain/track).

We are working on this. The final goal is using this info to enable
TCQ_F_CAN_BYPASS for nolock qdisc, too, as we see regressions in
uncontended scenarios with pfifo_fast compared to pre TCQ_F_NOLOCK
implementation.

Please let us know if the "empty/non_empty status" refactor is in your
radar, so we can avoid conflicts.

Thanks!

Paolo


      parent reply	other threads:[~2019-03-08 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 20:55 [PATCH net] net: sched: put back q.qlen into a single location Eric Dumazet
2019-03-02  7:07 ` David Miller
2019-03-02 22:11 ` David Miller
2019-03-03 21:32 ` John Fastabend
2019-03-08 11:01 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ccbbbc1393e55ee8a199b1bdd0e36087fa6d71d.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ivecera@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).