From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CC0C43381 for ; Fri, 8 Mar 2019 11:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58DD620854 for ; Fri, 8 Mar 2019 11:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbfCHLBs (ORCPT ); Fri, 8 Mar 2019 06:01:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45662 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfCHLBs (ORCPT ); Fri, 8 Mar 2019 06:01:48 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBAE93091784; Fri, 8 Mar 2019 11:01:47 +0000 (UTC) Received: from ovpn-116-253.ams2.redhat.com (ovpn-116-253.ams2.redhat.com [10.36.116.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9AF5600C8; Fri, 8 Mar 2019 11:01:42 +0000 (UTC) Message-ID: <2ccbbbc1393e55ee8a199b1bdd0e36087fa6d71d.camel@redhat.com> Subject: Re: [PATCH net] net: sched: put back q.qlen into a single location From: Paolo Abeni To: Eric Dumazet Cc: netdev , Eric Dumazet , John Fastabend , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Ivan Vecera , "David S . Miller" Date: Fri, 08 Mar 2019 12:01:41 +0100 In-Reply-To: <20190228205543.172713-1-edumazet@google.com> References: <20190228205543.172713-1-edumazet@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 08 Mar 2019 11:01:48 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Thank you for fixing this! On Thu, 2019-02-28 at 12:55 -0800, Eric Dumazet wrote: > Later (net-next) we might revert this patch by tracking all these > qlen uses and replace them by a more efficient method (not having > to access a precise qlen, but an empty/non_empty status that might > be less expensive to maintain/track). We are working on this. The final goal is using this info to enable TCQ_F_CAN_BYPASS for nolock qdisc, too, as we see regressions in uncontended scenarios with pfifo_fast compared to pre TCQ_F_NOLOCK implementation. Please let us know if the "empty/non_empty status" refactor is in your radar, so we can avoid conflicts. Thanks! Paolo