From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AFEC43381 for ; Wed, 20 Feb 2019 23:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBEB320859 for ; Wed, 20 Feb 2019 23:49:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbfBTXta (ORCPT ); Wed, 20 Feb 2019 18:49:30 -0500 Received: from smtprelay0061.hostedemail.com ([216.40.44.61]:37905 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726070AbfBTXta (ORCPT ); Wed, 20 Feb 2019 18:49:30 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 90FC4100E86C0; Wed, 20 Feb 2019 23:49:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fowl00_5288c7e2d5655 X-Filterd-Recvd-Size: 2107 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Wed, 20 Feb 2019 23:49:27 +0000 (UTC) Message-ID: <2cf3bf259bed9e44bd7e885850e45cb3a62e3779.camel@perches.com> Subject: Re: [PATCH v1 net-next 2/4] net: dsa: microchip: add MIB counter reading support From: Joe Perches To: Florian Fainelli , Tristram.Ha@microchip.com, andrew@lunn.ch Cc: sergio.paracuellos@gmail.com, pavel@ucw.cz, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Date: Wed, 20 Feb 2019 15:49:25 -0800 In-Reply-To: References: <1549598829-25970-1-git-send-email-Tristram.Ha@microchip.com> <1549598829-25970-3-git-send-email-Tristram.Ha@microchip.com> <20190209172249.GG30856@lunn.ch> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2019-02-12 at 19:51 -0800, Florian Fainelli wrote: > On February 12, 2019 6:39:49 PM PST, Tristram.Ha@microchip.com wrote: > > > > +static void ksz9477_freeze_mib(struct ksz_device *dev, int port, > > > > + bool freeze) > > > > +{ > > > > + struct ksz_port *p = &dev->ports[port]; > > > > + u32 val = freeze ? MIB_COUNTER_FLUSH_FREEZE : 0; > > > > > > Reverse Christmas tree. > > > > There was a checkpatch.pl patch in 2016 that tried to check this, but > > it was never accepted? https://lore.kernel.org/patchwork/patch/732076/ While I still think use of reverse christmas tree is misguided, there were some disagreements about what form it really is: Is this reverse christmas tree? void foo(void) { int aa; int a = 1; or is void foo(void) { int a = 1; int aa; IMHO: neither really helps to visually find or scan for automatics so the whole concept isn't particularly useful.