From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F163F86FA for ; Thu, 28 May 2026 16:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779987373; cv=none; b=GJLTU+I8mXyLzCwDgRA9a2VRczQQA5MmsOdiai+z34+ywIoRfbCbSeYFU2AO0FKEMnoT9jm+JWPjOZ/i/Z7ggv5gf3Csadhof+qGHU6gCo6l/+wSPkj3dIn3zCqeHC3fuKunmIlHAkjglG8xvLAwvCBZYbPA5JMHwHoVQKG4/kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779987373; c=relaxed/simple; bh=dRm6v9rJ98fryRZu+nDZ52gP6ZF+I/symBIWFqheIec=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R2UnTtgb/ytCX3UGbamx7Ool1j9BHKVl4X408CCzzWmcRuwQmgF37eXSeo5GosIu1X/PMXs020ZMA79m6zvBnwxHIxRbGvIvawuI1u1EUyYOeJhbwqShIl2uVUb3aASN2B6iBd8ouewQHZn8QOMbbehyWL5oC4pcZYf7FCiRq50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=axxvXFIh; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="axxvXFIh" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-69de237f0a3so1346620eaf.1 for ; Thu, 28 May 2026 09:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1779987369; x=1780592169; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WDGJeqE4tTfg/YKUkoTVnPS7Lm5TeqY7Toc0BSTB4Ms=; b=axxvXFIhScPMwL1SYv1SB/8Twa6Qjpy4MHe4/Zy7f+oNlk8eF6vcpwSjMxUCgkdaZk H2r4dgPHHu3jnBszJQpKbqLgekX8xr5tOZIcZbJbYQQIZ8ojEJRLFWpfSn02Vdt590Lj +JdTIeluvDz8KhKs9IORim7N+sgGXktxRB1C70gXOxClZT7XoGhKqYzsUg9V7gQMK4UQ QlnyMKWM+ISgiaifbHgBHXkboi3nHAgNX4VdKx0gQ4c9QFzxb5Lc246wAjsS2DSZdHMs J0fMheyMpMNKb9nzBIxJBG9v1ZmNg2RAwLMqUUokGc6eK8QKKzP0eW7ObVslwpDeP5lb H+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779987369; x=1780592169; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WDGJeqE4tTfg/YKUkoTVnPS7Lm5TeqY7Toc0BSTB4Ms=; b=sypyKapEypqvFdJxwmLqc5bJ5cyfHUKV0UQ7mVQd2bWdaNdr+NHazrmwdwuxj7TsLe 6CuFmEH3RIKUZxN65a3YbeG7LQFxVmgpN1HqCYO9oT0F1PTbD7aF3251uRqpjdhvBFqW gvkZiWV99u2BANA1RKK6raE0GBirfgKU/Qrn99lcNHw8XAUAV1eO3k7NTjq1O4KxuvL5 1kr7aQ+ssU/1NcsxjDCx1T2eRyydyudtt0kAm4n5/wvSkxzUx80SnjD7WAKCTEqZR8w3 m2uaJJKKv0MfWGrB6gk9MH7XWil8fnnXE0SusdviiFJVNiSfFwuc1mZFzSBmuCtzSXus jm3w== X-Forwarded-Encrypted: i=1; AFNElJ/CvYE+b53OO0s7lGVIrQfAifV+IXLmmBYy+5IN0/fNlr0vl1W21dWFo102yzK+ajZqg0Pniko=@vger.kernel.org X-Gm-Message-State: AOJu0YwpyqvJDfV19akyCIUX8Mfrq4EuRNULBbmaSkgvGgr79f0hs/Nr VxsOVkwBzO6ZYVzIXTO4XQsfHUiAiiTSv6kjrwaenJ/yGrYpgrztq7DGrC+eZ4/5CM0= X-Gm-Gg: Acq92OG0KKH4s876AKWcNqjwlIUqrKxGaNK2QKJtIRfgZ6XmHPWofB3j2XC1NcTOmEM J3yx9DWHU8Qw2x6LPrTiIghmiuYR2jyiU/CRFaG6gWvMp6mnZ2h1ZxTICGzMo2f4GLzLfgUrt2U hd/zhUAy0whzyFAYZsokwkdL6JMW8KF9J41E/csy7gU4yrV7LPsf3MXu9wtrYKQiwOCCnIyFY6p htlDivux0f2BTzbvtwVtz/r82C1xZTvclGbYi59I098tZ82BRiHkna3uQAeBMJrhkXK1MZJEdJF kIbVCi9sfRsws2H/wTKVFGcqgZJXZTxVXVKuyD/vv5bSCFge/TL3XGdDaQbpnLr4g08jZA+Izdr ySod1sO0/6RKspZzOmRL9t9rzzjThq1F/JNxN8f78hfXe3aDqm1tKqVxm1k8mQuV6Adh3lKVUae VDxSmmWzzJ9RJTIYdj4Thohq487/e/AoLxUTSWn4u1lZaJqlcSripCewcS/IF0LvqGPpUtlKlRn lEVTSjEp+vIQscge7g= X-Received: by 2002:a05:6820:4c07:b0:69b:5fcb:1a69 with SMTP id 006d021491bc7-69d7ed105b6mr14873551eaf.59.1779987369074; Thu, 28 May 2026 09:56:09 -0700 (PDT) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69e010cd4casm152656eaf.7.2026.05.28.09.56.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2026 09:56:08 -0700 (PDT) Message-ID: <2cfd6455-7b5b-4974-b8a1-4a0abca69768@kernel.dk> Date: Thu, 28 May 2026 10:56:06 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] net: Remove support for AIO on sockets To: Christoph Hellwig Cc: demiobenour@gmail.com, Herbert Xu , "David S. Miller" , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , Jakub Kicinski , Simon Horman , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Jonathan Corbet , Shuah Khan , Eric Biggers , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , linux-api@vger.kernel.org, David Howells References: <20260523-af-alg-harden-v1-0-c76755c3a5c5@gmail.com> <20260523-af-alg-harden-v1-1-c76755c3a5c5@gmail.com> <92db3ff0-8f0b-4b61-a167-5004ffcf9025@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/27/26 2:13 AM, Christoph Hellwig wrote: > On Tue, May 26, 2026 at 09:58:27AM -0600, Jens Axboe wrote: >>> The current TCP zerocopy implementation provides completion notification >>> through the socket error code, which is freaking weird and doesn't >>> integrate well with either io_uring or in-kernel callers. >> >> We already have that via io_uring > > Where? And how do make that available to in-kernel users like > storage protocols and network file system, which really suffer from > the current MSG_SPLICE_PAGES semantics. For zero copy, on both the receive and send side. Since we have a proper notification channel, that's what we use rather than the hack that is the error queue. >> , and without needing msg_kiocb or the > > What do you think is the downside of using a kiocb here like for > everything else with async notifications? Where would the notifications go? You'd end up inventing something new to propagate them to userspace then. The io_uring side does not rely on using msg_kiocb, and iirc that part was only ever used for the crypto stuff and largely broken. Which is why I do agree with just yanking it out. -- Jens Axboe