From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH v2] net: ethernet: mediatek: fix warning in phy_start_aneg Date: Wed, 9 Jan 2019 19:31:23 +0100 Message-ID: <2d3d2d19-b149-76e7-8013-ffb124b62f2b@gmail.com> References: <20190109072028.30513-1-frank-w@public-files.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Frank Wunderlich , Felix Fietkau , John Crispin , Sean Wang , Nelson Chang , "David S. Miller" , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <20190109072028.30513-1-frank-w@public-files.de> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09.01.2019 08:20, Frank Wunderlich wrote: > From: Heiner Kallweit > > linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: > > [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548 phy_start_aneg+0x110/0x144 > [ 5.178826] called from state READY > .... > [ 5.264111] [] (phy_start_aneg) from [] (mtk_init+0x414/0x47c) > [ 5.271630] r7:df5f5eec r6:c0f08c48 r5:00000000 r4:dea67800 > [ 5.277256] [] (mtk_init) from [] (register_netdevice+0x98/0x51c) > [ 5.285035] r8:00000000 r7:00000000 r6:c0f97080 r5:c0f08c48 r4:dea67800 > [ 5.291693] [] (register_netdevice) from [] (register_netdev+0x2c/0x44) > [ 5.299989] r8:00000000 r7:dea2e608 r6:deacea00 r5:dea2e604 r4:dea67800 > [ 5.306646] [] (register_netdev) from [] (mtk_probe+0x668/0x7ac) > [ 5.314336] r5:dea2e604 r4:dea2e040 > [ 5.317890] [] (mtk_probe) from [] (platform_drv_probe+0x58/0xa8) > [ 5.325670] r10:c0f86bac r9:00000000 r8:c0fbe578 r7:00000000 r6:c0f86bac r5:00000000 > [ 5.333445] r4:deacea10 > [ 5.335963] [] (platform_drv_probe) from [] (really_probe+0x2d8/0x424) > > maybe other boards using this generic driver are affected > > v2: > optimization: > > - phy_set_max_speed() is only needed if you want to reduce the > max speed, typically if the PHY supports 1Gbps but the MAC > supports 100Mbps only. > > - The pause parameters are autonegotiated. Except you have a specific > need you normally don't need to manually fiddle with this. > > - phy_start_aneg() is called implicitly by the phylib state machine, > you shouldn't call it manually except you have a good excuse. > > - netif_carrier_on/netif_carrier_off in mtk_phy_link_adjust() isn't > needed. It's done by phy_link_change() in phylib. > > Signed-off-by: Frank Wunderlich > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 16 ---------------- > 1 file changed, 16 deletions(-) > Reviewed-by: Heiner Kallweit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457A1C43387 for ; Wed, 9 Jan 2019 18:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DD5D20665 for ; Wed, 9 Jan 2019 18:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pm1bnovL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbfAISbg (ORCPT ); Wed, 9 Jan 2019 13:31:36 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38913 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbfAISbe (ORCPT ); Wed, 9 Jan 2019 13:31:34 -0500 Received: by mail-wr1-f67.google.com with SMTP id t27so8692439wra.6; Wed, 09 Jan 2019 10:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=sheBbn+PfpEMVz8/5nrRgnVPzMh1ftREYGKNb2yY60U=; b=Pm1bnovLWjxh9WaAgx8YVzLkn6cxgszAwORzrhtuRCPgue5Rl6a2vRW2eCjqI0kREB JuwCw5e2ubcFM7dYbAmIKHCL/owPqHpFLj1fPwVxuuuXYLgFoxqsNFzK/6UONE1QCo9f yZMlAjHIRnaTlN8V1hWjjq/rn7c7Ux7qHnDuk81ssgWyQR4ETSi1/937mK25E4QpfVdg H3GG//lyKmNfsPaSnk2x4oDbud/nA4aJjoT8RcRyQqOC1jwShTEWgO2jKi95z7zotjuF tW7e1TgrLsz07HCCSFVQMQA551dsssBgXMLG5Ppv4yWfPHN7fJ0JvdgP/6J51MyF7Xgp kIdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sheBbn+PfpEMVz8/5nrRgnVPzMh1ftREYGKNb2yY60U=; b=PAe3QoZFIshMjjmgUqFGdymFcVuqWBliZqcfhuevxtqeRpOZZtDZwLQjizU6vM5jeg D62/xhDAEhv74Tv6V+z7o2Ok9pzjvUFCalQ5HV3cgvD5Uh7syhAZNn3AHrEUTE5I2bMq 0u5eNtk8WNvKH8IX24FSn4jXQA4s7+3SYNqHB05K5WYK8m/9pJr7SJ23M5I3Crn8qx5F 2kC3w91yHxhB8AnMInGltJsLzuqEPazWn2L3gOwwecvM1cHzwmH7DqV8ySGq0QFudxTV zM9iUz+8uF5Ajy8bAor2CSdwE+hDWEdxToEd++/x0CH7i0Vp8hnOJFBtPQQizaFbKNKL LRZw== X-Gm-Message-State: AJcUukc8CkDif5Bj1ppaLcfq/00b9ZC3/VbY7nRWtBzw9zImJOxNj46Q 7XXwmj3DVIR2DQSuqjZnEXBhv3YU X-Google-Smtp-Source: ALg8bN4NaUZqCRfMDvjqByIArR9MDac6FD7XQSvGnTLRESVNkjbDMb3nS3y9ZUs8YXRaaoPx9WdbAA== X-Received: by 2002:a5d:6889:: with SMTP id h9mr6031538wru.222.1547058691763; Wed, 09 Jan 2019 10:31:31 -0800 (PST) Received: from ?IPv6:2003:ea:8be2:e400:30af:bb11:dc41:cedc? (p200300EA8BE2E40030AFBB11DC41CEDC.dip0.t-ipconnect.de. [2003:ea:8be2:e400:30af:bb11:dc41:cedc]) by smtp.googlemail.com with ESMTPSA id c14sm13869999wme.13.2019.01.09.10.31.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 10:31:30 -0800 (PST) Subject: Re: [PATCH v2] net: ethernet: mediatek: fix warning in phy_start_aneg To: Frank Wunderlich , Felix Fietkau , John Crispin , Sean Wang , Nelson Chang , "David S. Miller" , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190109072028.30513-1-frank-w@public-files.de> From: Heiner Kallweit Message-ID: <2d3d2d19-b149-76e7-8013-ffb124b62f2b@gmail.com> Date: Wed, 9 Jan 2019 19:31:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190109072028.30513-1-frank-w@public-files.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Message-ID: <20190109183123.Xm3Tsd3GW2GSn4_hwc5tD9eNyeUS3SemcwXR-Iipl9U@z> On 09.01.2019 08:20, Frank Wunderlich wrote: > From: Heiner Kallweit > > linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: > > [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548 phy_start_aneg+0x110/0x144 > [ 5.178826] called from state READY > .... > [ 5.264111] [] (phy_start_aneg) from [] (mtk_init+0x414/0x47c) > [ 5.271630] r7:df5f5eec r6:c0f08c48 r5:00000000 r4:dea67800 > [ 5.277256] [] (mtk_init) from [] (register_netdevice+0x98/0x51c) > [ 5.285035] r8:00000000 r7:00000000 r6:c0f97080 r5:c0f08c48 r4:dea67800 > [ 5.291693] [] (register_netdevice) from [] (register_netdev+0x2c/0x44) > [ 5.299989] r8:00000000 r7:dea2e608 r6:deacea00 r5:dea2e604 r4:dea67800 > [ 5.306646] [] (register_netdev) from [] (mtk_probe+0x668/0x7ac) > [ 5.314336] r5:dea2e604 r4:dea2e040 > [ 5.317890] [] (mtk_probe) from [] (platform_drv_probe+0x58/0xa8) > [ 5.325670] r10:c0f86bac r9:00000000 r8:c0fbe578 r7:00000000 r6:c0f86bac r5:00000000 > [ 5.333445] r4:deacea10 > [ 5.335963] [] (platform_drv_probe) from [] (really_probe+0x2d8/0x424) > > maybe other boards using this generic driver are affected > > v2: > optimization: > > - phy_set_max_speed() is only needed if you want to reduce the > max speed, typically if the PHY supports 1Gbps but the MAC > supports 100Mbps only. > > - The pause parameters are autonegotiated. Except you have a specific > need you normally don't need to manually fiddle with this. > > - phy_start_aneg() is called implicitly by the phylib state machine, > you shouldn't call it manually except you have a good excuse. > > - netif_carrier_on/netif_carrier_off in mtk_phy_link_adjust() isn't > needed. It's done by phy_link_change() in phylib. > > Signed-off-by: Frank Wunderlich > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 16 ---------------- > 1 file changed, 16 deletions(-) > Reviewed-by: Heiner Kallweit