From: Paolo Abeni <pabeni@redhat.com>
To: Jason Xing <kerneljasonxing@gmail.com>,
edumazet@google.com, dsahern@kernel.org, matttbe@kernel.org,
martineau@kernel.org, geliang@kernel.org, kuba@kernel.org,
davem@davemloft.net, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, atenart@kernel.org
Cc: mptcp@lists.linux.dev, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v4 3/6] rstreason: prepare for active reset
Date: Tue, 16 Apr 2024 10:01:27 +0200 [thread overview]
Message-ID: <2d3ea199eef53cf6a0c48e21abdee0eefbdee927.camel@redhat.com> (raw)
In-Reply-To: <20240411115630.38420-4-kerneljasonxing@gmail.com>
On Thu, 2024-04-11 at 19:56 +0800, Jason Xing wrote:
> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index 744c87b6d5a4..ba0a252c113f 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -412,7 +412,7 @@ void mptcp_subflow_reset(struct sock *ssk)
> /* must hold: tcp_done() could drop last reference on parent */
> sock_hold(sk);
>
> - tcp_send_active_reset(ssk, GFP_ATOMIC);
> + tcp_send_active_reset(ssk, GFP_ATOMIC, SK_RST_REASON_NOT_SPECIFIED);
I'm sorry for the late feedback.
Some of the caller can set subflow->reset_reason, so probably something
alike the following:
tcp_send_active_reset(ssk, GFP_ATOMIC,
subflow->reset_reason?: SK_RST_REASON_NOT_SPECIFIED);
would work - with an helper even better.
Could be a follow-up patch.
Thanks,
Paolo
next prev parent reply other threads:[~2024-04-16 8:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 11:56 [PATCH net-next v4 0/6] Implement reset reason mechanism to detect Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 1/6] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 2/6] rstreason: prepare for passive reset Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 3/6] rstreason: prepare for active reset Jason Xing
2024-04-16 8:01 ` Paolo Abeni [this message]
2024-04-16 8:27 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 4/6] tcp: support rstreason for passive reset Jason Xing
2024-04-16 6:34 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 12:24 ` Jason Xing
2024-04-16 20:22 ` Matthieu Baerts
2024-04-17 0:23 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 5/6] mptcp: " Jason Xing
2024-04-16 6:33 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 8:04 ` Paolo Abeni
2024-04-16 8:19 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 6/6] rstreason: make it work in trace world Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d3ea199eef53cf6a0c48e21abdee0eefbdee927.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matttbe@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).