From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding Date: Wed, 4 Jul 2018 12:36:51 -0600 Message-ID: <2d75173b-b6f2-974c-32c2-df29bffd6a6a@gmail.com> References: <62ecbcf0c905dde3bfde51cd260e2f7c59e21028.1530512974.git.lucien.xin@gmail.com> <03b43b2dbda208510514082b2bd94643c3a6580c.1530512974.git.lucien.xin@gmail.com> <5e5f7edf-1313-cfef-9005-b05ec9051b25@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: network dev , davem , Davide Caratti , Ido Schimmel To: Xin Long Return-path: Received: from mail-pl0-f44.google.com ([209.85.160.44]:33719 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbeGDSgy (ORCPT ); Wed, 4 Jul 2018 14:36:54 -0400 Received: by mail-pl0-f44.google.com with SMTP id 6-v6so122178plb.0 for ; Wed, 04 Jul 2018 11:36:54 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 7/4/18 11:56 AM, Xin Long wrote: >> your commands are not a proper test. The test should succeed and fail >> based on the routing lookup, not iptables rules. > A proper test can be done easily with netns, as vrf can't isolate much. > I don't want to bother forwarding/ directory with netns, so I will probably > just drop this selftest, and let the feature patch go first. > BTW, VRF isolates at the routing layer and this is a routing change. We need to understand why it does not work with VRF. Perhaps another tweak is needed for VRF.