From: "Arnd Bergmann" <arnd@arndb.de>
To: "Richard Cochran" <richardcochran@gmail.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Arun Ramadoss" <arun.ramadoss@microchip.com>,
"Jacob Keller" <jacob.e.keller@intel.com>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: ptp: add one more PTP dependency
Date: Sat, 28 Jan 2023 22:44:22 +0100 [thread overview]
Message-ID: <2d90460c-9d30-46cb-871e-e2500243ffd3@app.fastmail.com> (raw)
In-Reply-To: <Y9RlHIqbVNG7SoDw@hoboy.vegasvil.org>
On Sat, Jan 28, 2023, at 00:58, Richard Cochran wrote:
> On Fri, Jan 27, 2023 at 11:13:03PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> When only NET_DSA_MICROCHIP_KSZ8863_SMI is built-in but
>> PTP is a loadable module, the ksz_ptp support still causes
>> a link failure:
>>
>> ld.lld-16: error: undefined symbol: ptp_clock_index
>> >>> referenced by ksz_ptp.c
>> >>> drivers/net/dsa/microchip/ksz_ptp.o:(ksz_get_ts_info) in archive vmlinux.a
>>
>> Add the same dependency here that exists with the KSZ9477_I2C
>> and KSZ_SPI drivers.
>>
>> Fixes: eac1ea20261e ("net: dsa: microchip: ptp: add the posix clock support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
The randconfig builder just found another regression in the same
driver, I'll have to send a new version, so please disregard this one
for now.
Arnd
prev parent reply other threads:[~2023-01-28 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 22:13 [PATCH] net: dsa: microchip: ptp: add one more PTP dependency Arnd Bergmann
2023-01-27 23:58 ` Richard Cochran
2023-01-28 21:44 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d90460c-9d30-46cb-871e-e2500243ffd3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arnd@kernel.org \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).