From: Yonghong Song <yhs@fb.com>
To: Brian Vazquez <brianvv@google.com>,
Brian Vazquez <brianvv.kernel@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH bpf-next] bpf: Fix memory leaks in generic update/delete batch ops
Date: Sat, 18 Jan 2020 04:14:07 +0000 [thread overview]
Message-ID: <2d954f70-a2d0-85c7-33c8-c71d6ed9572d@fb.com> (raw)
In-Reply-To: <20200117225608.220838-1-brianvv@google.com>
On 1/17/20 2:56 PM, Brian Vazquez wrote:
> generic update/delete batch ops functions were using __bpf_copy_key
> without properly freeing the memory. Handle the memory allocation and
> copy_from_user separately.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: aa2e93b8e58e ("bpf: Add generic support for update and delete
> batch ops")
Please put the subject of Fixes commit in the same line.
This will make tools easier to grep "Fixes" tag.
> Signed-off-by: Brian Vazquez <brianvv@google.com>
Acked-by: Yonghong Song <yhs@fb.com>
prev parent reply other threads:[~2020-01-18 4:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 22:56 [PATCH bpf-next] bpf: Fix memory leaks in generic update/delete batch ops Brian Vazquez
2020-01-18 4:14 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d954f70-a2d0-85c7-33c8-c71d6ed9572d@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brianvv.kernel@gmail.com \
--cc=brianvv@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).