From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B97C43381 for ; Sat, 16 Feb 2019 22:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB8D821A4C for ; Sat, 16 Feb 2019 22:45:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rChd9w3B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387456AbfBPWp6 (ORCPT ); Sat, 16 Feb 2019 17:45:58 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42003 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbfBPWp6 (ORCPT ); Sat, 16 Feb 2019 17:45:58 -0500 Received: by mail-wr1-f68.google.com with SMTP id r5so786434wrg.9 for ; Sat, 16 Feb 2019 14:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BY6UIiPXhXVx0rMT7Wd+w0pg+s3l8rBskqfbcXApXb0=; b=rChd9w3BF8DHGyMQqqqtqGl6JGX7HuOZKssMwJWhjdLAJ/12eDt18oWj78v9UoWc3a 6Tab+IsI+se9B2IstlVMxcS1GOwmgt8tAfhcHOJ4AVVsbXtnwvYrTRMZcyEknhyaten2 hcKxyhviAY4UClATKHCJoQo1d3BXlOcCLqRehOQMEm1Kt9KPrAK5ZijPBY0RwkViFlC9 W0AP0Yt5RV4BeCLAcX04svkm2A1dYGL1jZAvEJJoFSkrQV+WKMQ/sSKJazKb6pVpCkmb G/j5JdsRYd7q3UKla+yCk1l/Z9V33n0XrwzFAP/6NKcOK3cjo6or9cOb5b1ScexdalpW Q8mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BY6UIiPXhXVx0rMT7Wd+w0pg+s3l8rBskqfbcXApXb0=; b=o9Fv6nlyiyfc1/hf1IsC37yi3vxfp3Ft1DIjbitkfDpv46r9RbMq5P0Izx+1RL6F5n 3Ck2k8o4pFpostugw1er2mvhLP07WC9LTtIEO7Dp1QWc/Q3BtRZGvNKnm9yhNW/lvJbO l65njU5Wn/dcmTId6FoDLM3iwfbSHJr/1aXCtaYDOd2HElR3QWmd2zOvrrF5aykETpkM oCCFqh7KSdfZmA9Ir3X+Rd+r2onscGsGpPd/8c2EuU3DtERW2CqrOUZvLZJy7zxcDMHQ Mfs1E6WaxZ+fnjj1MdJ1Vg+lqPK9GMO31apO79mXsKnn1UhV5H3OBGpaT4Y+gKx99mIs 8hSA== X-Gm-Message-State: AHQUAuZZgFw1FEbO3jqJlBR18Jq4NzvvKZqKLCLEiltRqQdyccSCjvP9 X6jhejfDGL5fy7mbInoaEm+aTCuD X-Google-Smtp-Source: AHgI3IYqIsDryD4QVx3NRajBign0LOdnI3lbm8YhRFDsGuJTbmnWz6byicOe9Uv6Rwk6qu8WRY2LJg== X-Received: by 2002:a5d:620d:: with SMTP id y13mr11496604wru.119.1550357156494; Sat, 16 Feb 2019 14:45:56 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:fc50:d076:bfa9:dffa? (p200300EA8BF1E200FC50D076BFA9DFFA.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:fc50:d076:bfa9:dffa]) by smtp.googlemail.com with ESMTPSA id q78sm1529414wme.43.2019.02.16.14.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 14:45:55 -0800 (PST) Subject: Re: [PATCH net-next 1/2] net: phy: disable aneg in genphy_c45_pma_setup_forced To: Russell King - ARM Linux admin Cc: Andrew Lunn , Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <8945c224-bfff-294d-f855-979016e077ec@gmail.com> <27bb134f-eb4e-e43a-5d9d-2c551a22428c@gmail.com> <20190216224320.kwefivz2kpzqnmqm@shell.armlinux.org.uk> From: Heiner Kallweit Message-ID: <2d9b820f-cd55-ca9d-0904-9309ea937805@gmail.com> Date: Sat, 16 Feb 2019 23:45:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190216224320.kwefivz2kpzqnmqm@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16.02.2019 23:43, Russell King - ARM Linux admin wrote: > On Sat, Feb 16, 2019 at 08:10:24PM +0100, Heiner Kallweit wrote: >> When genphy_c45_pma_setup_forced() is called the "aneg enabled" bit may >> still be set, therefore clear it. This is also in line with what >> genphy_setup_forced() does for Clause 22. >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/net/phy/phy-c45.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c >> index bef126344..0374c50b1 100644 >> --- a/drivers/net/phy/phy-c45.c >> +++ b/drivers/net/phy/phy-c45.c >> @@ -71,6 +71,10 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) >> return ret; >> >> return phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL2, ctrl2); >> + if (ret < 0) > > This patch does not make sense. > Right, was a typo. Interestingly the compiler didn't complain. I sent a v2 already. >> + return ret; >> + >> + return genphy_c45_an_disable_aneg(phydev); >> } >> EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); >> >> -- >> 2.20.1 >> >> >> >