From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"open list:BROADCOM GENET ETHERNET DRIVER"
<bcm-kernel-feedback-list@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: bcmgenet: Add support for 7712 16nm internal EPHY
Date: Fri, 22 Oct 2021 12:38:45 -0700 [thread overview]
Message-ID: <2da4e5f6-63d8-73d6-7dbd-e3e541f91ac5@gmail.com> (raw)
In-Reply-To: <YXMS23QSf55r8vBT@lunn.ch>
Hello Andrew,
On 10/22/21 12:36 PM, Andrew Lunn wrote:
> On Fri, Oct 22, 2021 at 09:17:03AM -0700, Florian Fainelli wrote:
>> The 16nm internal EPHY that is present in 7712 is actually a 16nm
>> Gigabit PHY which has been forced to operate in 10/100 mode.
>
> Hi Florian
>
> Will genphy_read_abilities() detect it as a 1G PHY? Does bcmgenet.c
> need to call phy_set_max_speed() to stop it advertising 1G?
That is not necessary, the capabilities have been adjusted accordingly,
the PHY only advertises 10/100 and not above.
--
Florian
next prev parent reply other threads:[~2021-10-22 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 16:17 [PATCH net-next 0/3] Support for 16nm EPHY in GENET Florian Fainelli
2021-10-22 16:17 ` [PATCH net-next 1/3] net: phy: bcm7xxx: Add EPHY entry for 7712 Florian Fainelli
2021-10-22 19:30 ` Andrew Lunn
2021-10-22 16:17 ` [PATCH net-next 2/3] dt-bindings: net: bcmgenet: Document 7712 binding Florian Fainelli
2021-10-22 19:30 ` Andrew Lunn
2021-10-22 16:17 ` [PATCH net-next 3/3] net: bcmgenet: Add support for 7712 16nm internal EPHY Florian Fainelli
2021-10-22 19:36 ` Andrew Lunn
2021-10-22 19:38 ` Florian Fainelli [this message]
2021-10-24 12:50 ` [PATCH net-next 0/3] Support for 16nm EPHY in GENET patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2da4e5f6-63d8-73d6-7dbd-e3e541f91ac5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).