From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
network dev <netdev@vger.kernel.org>,
David Ahern <dsa@cumulusnetworks.com>
Subject: Re: iproute2 broken vlan stats output
Date: Tue, 16 Apr 2019 17:33:47 +0300 [thread overview]
Message-ID: <2da90287-6526-5523-9e58-7f00a9dd1781@cumulusnetworks.com> (raw)
In-Reply-To: <CAJieiUiYQh-NhdbPpX_4ee16KBYtYRUHaZVqUVJ6mRJyDQncFg@mail.gmail.com>
On 16/04/2019 17:28, Roopa Prabhu wrote:
> On Tue, Apr 16, 2019 at 5:38 AM Nikolay Aleksandrov
> <nikolay@cumulusnetworks.com> wrote:
>>
>> Hi Stephen,
>> It seems standard (non-json) vlan stats output has been broken since commit:
>> 0f36267485e3 ("bridge: fix vlan show formatting")
>>
>> bridge -s vlan show output before commit 0f36267485e3:
>> port vlan id
>> br0 1 PVID untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packets
>> eth4 1 PVID untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packets
>>
>> bridge -s vlan show output after commit 0f36267485e3:
>> root@debian~/# bridge -s vlan
>> port vlan id
>> br0br0 1 PVID Egress Untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packetseth4eth4 1 PVID Egress Untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packetsroot@debian:~/#
>>
>
> :(. Looks like iproute2 should have selftests too. Its hard to catch
> these in code review.
>
I made a mistake about the commit, the actual culprits are:
45fca4ed9412 ("bridge: fix vlan show stats formatting")
c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
They both broke a different thing about standard stats output:
- 45fca4ed9412 ("bridge: fix vlan show stats formatting")
Added a second print of an interface name (e.g. eth4eth4)
- c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
Broke normal vlan stats output by not printing a new line after them
I'll post a fix in a minute.
next prev parent reply other threads:[~2019-04-16 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 12:38 iproute2 broken vlan stats output Nikolay Aleksandrov
2019-04-16 14:28 ` Roopa Prabhu
2019-04-16 14:33 ` Nikolay Aleksandrov [this message]
2019-04-16 15:14 ` [PATCH iproute2] bridge: vlan: fix standard " Nikolay Aleksandrov
2019-04-16 15:30 ` [PATCH iproute2 v2] " Nikolay Aleksandrov
2019-04-17 23:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2da90287-6526-5523-9e58-7f00a9dd1781@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).