From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: David Miller <davem@davemloft.net>, gustavo@embeddedor.com
Cc: santosh@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb3: remove VLA
Date: Wed, 7 Mar 2018 11:30:39 -0600 [thread overview]
Message-ID: <2dbb7aba-4e12-c4df-363e-b65fcbb16d0e@embeddedor.com> (raw)
In-Reply-To: <20180307.122541.1396477885969641264.davem@davemloft.net>
On 03/07/2018 11:25 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 5 Mar 2018 23:39:34 -0600
>
>> In preparation to enabling -Wvla, remove VLA and replace it
>> with dynamic memory allocation.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> All of these lengths are limited by the encoding of the field in the
> VPD, which is a u8, and thus 255 bytes.
>
> Please just change the 'len' argument to these functions to a u8 and
> use a 256 byte buffer on the stack.
>
> Thanks.
>
OK. I got it.
Thanks for the feedback.
--
Gustavo
prev parent reply other threads:[~2018-03-07 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 5:39 [PATCH] cxgb3: remove VLA Gustavo A. R. Silva
2018-03-07 17:25 ` David Miller
2018-03-07 17:30 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dbb7aba-4e12-c4df-363e-b65fcbb16d0e@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).