From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, Chris Mi <cmi@nvidia.com>
Cc: netdev@vger.kernel.org, jiri@nvidia.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency
Date: Mon, 01 Feb 2021 23:31:15 -0800 [thread overview]
Message-ID: <2dbcb5f51fd2ad1296c4391d45a854fef3438420.camel@kernel.org> (raw)
In-Reply-To: <20210201171441.46c0edaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, 2021-02-01 at 17:14 -0800, Jakub Kicinski wrote:
> On Mon, 1 Feb 2021 10:04:12 +0800 Chris Mi wrote:
> > In order to send sampled packets to userspace, NIC driver calls
> > psample api directly. But it creates a hard dependency on module
> > psample. Introduce psample_ops to remove the hard dependency.
> > It is initialized when psample module is loaded and set to NULL
> > when the module is unloaded.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Chris Mi <cmi@nvidia.com>
> > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>
> The necessity of making this change is not obvious (you can fix the
> distro scripts instead), you did not include a clarification in the
> commit message even though two people asked you why it's needed and
> on top of that you keep sending code which doesn't build.
>
> Please consider this change rejected and do not send a v7.
Jakub, it is not only about installation dependencies, the issue is
more critical than this,
We had some other issues with similar dependency problem where
mlx5_core had hard dependency with netfilter, firewalld when disabled,
removes netfilter and all its dependencies including mlx5, this is a no
go for our users.
Again, having a hard dependency between a hardware driver and a
peripheral module in the kernel is a bad design.
next prev parent reply other threads:[~2021-02-02 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 2:04 [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency Chris Mi
2021-02-02 1:14 ` Jakub Kicinski
2021-02-02 7:31 ` Saeed Mahameed [this message]
2021-02-02 21:24 ` Jakub Kicinski
2021-02-02 21:43 ` Saeed Mahameed
2021-02-03 2:55 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dbcb5f51fd2ad1296c4391d45a854fef3438420.camel@kernel.org \
--to=saeed@kernel.org \
--cc=cmi@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).