From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E762C433DB for ; Tue, 2 Feb 2021 07:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B81864EE2 for ; Tue, 2 Feb 2021 07:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231488AbhBBHb7 (ORCPT ); Tue, 2 Feb 2021 02:31:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:55512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbhBBHb5 (ORCPT ); Tue, 2 Feb 2021 02:31:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7ECF464DDD; Tue, 2 Feb 2021 07:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612251077; bh=Mrx9qD7GIvptVBf+wCkQGpdoSGiEeCooPaAknwRyD2E=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UfPUYucFcFQ66Sigo/airKpEduzalkpoiJEfx9WNVhB7ds3pfJDDg9GSOqmwGkBuV bmVtmZHiiyIUD3PhHeSRyycS5PkKQHfSbGyaNACgOIKJz9Q13o7p2J+HCaoEJ5Ti1O 1VlZs71Hi8pgG4W26Nve0Do/ZXn6F33fjZLF/6ADeb2V61FW1UjUv24jpNpKguenMV 4cg85amH//6+mf0aBrYUfilznrQYEOrw8ajnmmm9MoVw4N99wSxPumXGkXksepIAfs ZiI7P8X/ex7zYfVbA5Fq/mrxaJh+GaZ4E8QTftohJ9CiEuziSYgvFmpMg7WRjLfgkq aEQvoHSiyPFEg== Message-ID: <2dbcb5f51fd2ad1296c4391d45a854fef3438420.camel@kernel.org> Subject: Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency From: Saeed Mahameed To: Jakub Kicinski , Chris Mi Cc: netdev@vger.kernel.org, jiri@nvidia.com, kernel test robot Date: Mon, 01 Feb 2021 23:31:15 -0800 In-Reply-To: <20210201171441.46c0edaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210201020412.52790-1-cmi@nvidia.com> <20210201171441.46c0edaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2021-02-01 at 17:14 -0800, Jakub Kicinski wrote: > On Mon,  1 Feb 2021 10:04:12 +0800 Chris Mi wrote: > > In order to send sampled packets to userspace, NIC driver calls > > psample api directly. But it creates a hard dependency on module > > psample. Introduce psample_ops to remove the hard dependency. > > It is initialized when psample module is loaded and set to NULL > > when the module is unloaded. > > > > Reported-by: kernel test robot > > Signed-off-by: Chris Mi > > Reviewed-by: Jiri Pirko > > The necessity of making this change is not obvious (you can fix the > distro scripts instead), you did not include a clarification in the > commit message even though two people asked you why it's needed and > on top of that you keep sending code which doesn't build. > > Please consider this change rejected and do not send a v7. Jakub, it is not only about installation dependencies, the issue is more critical than this, We had some other issues with similar dependency problem where mlx5_core had hard dependency with netfilter, firewalld when disabled, removes netfilter and all its dependencies including mlx5, this is a no go for our users. Again, having a hard dependency between a hardware driver and a peripheral module in the kernel is a bad design.