From: Roi Dayan <roid@nvidia.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
David Ahern <dsahern@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Davide Caratti <dcaratti@redhat.com>
Cc: <netdev@vger.kernel.org>, Paul Blakey <paulb@nvidia.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
Roman Mashak <mrv@mojatatu.com>,
Baowen Zheng <baowen.zheng@corigine.com>
Subject: Re: [PATCH iproute2-next v4 1/1] police: Add support for json output
Date: Mon, 12 Jul 2021 15:28:58 +0300 [thread overview]
Message-ID: <2dc2bcf7-e953-a1a4-d015-40de72d1f8aa@nvidia.com> (raw)
In-Reply-To: <5324ca9a-6671-2698-f6a4-4ac94ad7bc26@mojatatu.com>
On 2021-07-12 2:02 PM, Jamal Hadi Salim wrote:
> On 2021-07-11 12:00 p.m., David Ahern wrote:
>
>>> ...
>>> action order 1: police 0x1 rate 1Mbit burst 20Kb mtu 2Kb
>>> action
>>> reclassify overhead 0b
>>>
>>>
>>>
>>>
>>> - print_string(PRINT_ANY, "kind", "%s", "police");
>>> + print_string(PRINT_JSON, "kind", "%s", "police");
>>>
>>> - print_uint(PRINT_ANY, "index", "\tindex %u ", p->index);
>>> + print_hex(PRINT_FP, NULL, " police 0x%x ", p->index);
>>> + print_uint(PRINT_JSON, "index", NULL, p->index);
>>>
>>>
>>
>> Jamal: opinions?
>
> Looks good to me. Roi please run the kernel tests to make sure
> nothing breaks.
>
> cheers,
> jamal
>
ok
I sent patch titled "police: Fix normal output back to what it was"
I ran the tdc tests and passed.
next prev parent reply other threads:[~2021-07-12 12:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 6:44 [PATCH iproute2-next v4 1/1] police: Add support for json output Roi Dayan
2021-06-11 2:35 ` David Ahern
2021-07-05 10:41 ` Hangbin Liu
2021-07-06 8:27 ` Davide Caratti
2021-07-07 6:53 ` Hangbin Liu
2021-07-08 6:57 ` Roi Dayan
2021-07-08 7:23 ` Roi Dayan
2021-07-08 14:46 ` David Ahern
2021-07-11 10:24 ` Roi Dayan
2021-07-11 16:00 ` David Ahern
2021-07-12 11:02 ` Jamal Hadi Salim
2021-07-12 12:28 ` Roi Dayan [this message]
2021-07-05 16:28 ` Stephen Hemminger
2021-07-05 16:30 ` David Ahern
2021-07-06 8:30 ` Roi Dayan
2021-07-06 8:36 ` Roi Dayan
2021-07-05 16:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc2bcf7-e953-a1a4-d015-40de72d1f8aa@nvidia.com \
--to=roid@nvidia.com \
--cc=baowen.zheng@corigine.com \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=liuhangbin@gmail.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).