From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FA7A158DC4 for ; Wed, 13 Nov 2024 17:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731518866; cv=none; b=UBC5PmV+WCExR0yeSRwUHhSlUpFdNF5Ts0neHKVGv3nFSAv2GF73OAJtm/4mb7QI64JsD/OABO2OKLLlAbc273mAiXvSHku36SeIDde2FvD6af7/XET5OBEDtM1OEdVuOhGk6hK9/ANThRFWfdatTXsm7wPUiHjldkiTnMIENto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731518866; c=relaxed/simple; bh=gJOLo2v8Fi931b0PuXOlRWTscuHccmq+3zjXTLBq7Yo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pEnW+ZnddLb60QnPSKDdcJ1wCfPC8d8Pv5AcA/aXjcoRa7+clooydVc5ef9jKlX8EFUjV1DFkg9wu4+sVtlGjf4TuUko0J/IjYZDd8iWiK4W0VC/iysR6ZmHlGJ2v11O0wZiwc6+FFIFrNSaDMEDnhK75U6hDFMX5tscMxTtfic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N1kbI14m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N1kbI14m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61E98C4CEC3; Wed, 13 Nov 2024 17:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731518865; bh=gJOLo2v8Fi931b0PuXOlRWTscuHccmq+3zjXTLBq7Yo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N1kbI14m3Nb/0YbpU73q8M65h6Gb1AImcl/Y/w1R9tIGnoH0AQcKIRJxDzQ0QSfcC XDeRMttjFSvY8FTkEHS20Bc832QmWSNg8B7Ncn/QhuznI0EHJUT2Wfkbn/D8h6O5zv OboFxKHlNBrDWVOVEMpXqRoD/rn9Eo2iBRlwnmrGdbU2dfy1hEpr0W47yqmlPETgfK amPTjTNphK3AUT0hhhMVn4Ow2hIVdY34f8g7k/C+lcSvi4ad20/Z8+2JGJPX8MPmy+ IO373XzR98VaIa18d4jiJ7pQ1Oz8lAmP6fvPjHI+cSjsXZkJLq7K4FGetlEbaFaVN1 opTG6iQFwllvg== Message-ID: <2df9d232-9d87-4c0d-b910-b82a0ba68986@kernel.org> Date: Wed, 13 Nov 2024 09:27:44 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] ipv6: route: release reference of dsts cached in sockets Content-Language: en-US To: Xin Long , Jiri Wiesner Cc: Eric Dumazet , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" References: <20240930180916.GA24637@incl> <20241001152609.GA24007@incl> <20241003170126.GA20362@incl> <20241112085655.GA19776@incl> From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/12/24 2:51 PM, Xin Long wrote: > This makes sense to me. > > The code prior to 92f1655aa2b22 ("net: fix __dst_negative_advice() > race") had no longer been able to release the cached dst for the > reference held by socket in ip6_negative_advice() since > rt6_remove_exception_rt() is called there. > > Hi, David Ahern, > > Can you confirm this? > > Thanks. I am traveling this week, so even less time than usual for patches. I will need to find to refresh my memory on the history of the code.