From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77FB1C10F0E for ; Mon, 15 Apr 2019 15:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4978420880 for ; Mon, 15 Apr 2019 15:07:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RmMGK8Up" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727671AbfDOPHI (ORCPT ); Mon, 15 Apr 2019 11:07:08 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:55712 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727523AbfDOPHH (ORCPT ); Mon, 15 Apr 2019 11:07:07 -0400 Received: by mail-it1-f196.google.com with SMTP id y134so27501804itc.5 for ; Mon, 15 Apr 2019 08:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yOZzHb0+5zxg61MV1i9J00miuals9Jj97/3f6eBqz68=; b=RmMGK8UpBesza1alIZdvcaG/GM0kaxl4wrkUufX6DscOTRk611COlupueS8Qqg7YKB SCyQPCjVDQ7VE1PRfBa4j2vJPA6p9z8kwCJesfGfBCIkjfwfspTThJy0E9uPGpSIcKES 8z/TTJai4w0mzIGWG4EJ/Nn/JTqa0RG1KNAFESnUxeFceCNFhBTRTnsHKa6bo1zIvw2g nuWgyuO1QehusbycpWE+nOv0OVqVLzwqMozR4X243CftE2BaRSn5rpx9cL1sGdcBvNok SYBUYxsNzf9FAJxRBKWG8+3HDSKIvGw4gCEbsBnzC/qebLtifarY9t4TKEt5y3Y+sKF0 CTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yOZzHb0+5zxg61MV1i9J00miuals9Jj97/3f6eBqz68=; b=RahDN1fSf6gOU8o1JWoWa4pa3LSJ/P5gmwuToAiRueTYdToUdIHGaFe+8CrYBF5ltf 7WI2zd2cWhx+Xgbe3MigetS8bx0bUPLnNTTgfeTejU22mdbog+S7E5vPV1YT24ZxT1AH yLki7gg6gYD6HbgKDDZ1xm3+Ofby+Lf3S0/0frUMBuxyAChABAjFCZMYmV51kQ1u726B idV46lWRspx8tauIH2OE8sMdEB9xs4dYDhGSSEmYuLXab5QkjQQ19GUJDb6nLgKQ4YlZ 5i81af5KuZUCwQQeWE6uzK3mCOdLLGdnF7SOQp8xMrd+HMl/wp14h8BUsgl2hpeWw8TG oFvA== X-Gm-Message-State: APjAAAUZbL6vhx1BeO7OMRBqhlhvAOaE55tJaU+M2ejpaIRpwPfhMC6O 92wOD0BdNsZOf59SsCl6O0gBRT/V X-Google-Smtp-Source: APXvYqzfKRwWrWOytXPtSzSh5Wnjd0cBf0s2QgG+VbgmO3SPfdSPnqDLU8TGynlemrA4pw/VSXH5Cg== X-Received: by 2002:a02:a50a:: with SMTP id e10mr51588535jam.104.1555340826910; Mon, 15 Apr 2019 08:07:06 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:91ac:460f:1e02:116c? ([2601:282:800:fd80:91ac:460f:1e02:116c]) by smtp.googlemail.com with ESMTPSA id u66sm19035945ioe.74.2019.04.15.08.07.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2019 08:07:05 -0700 (PDT) Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, jakub.kicinski@netronome.com References: <20190413162112.8203-1-jiri@resnulli.us> <20190413162112.8203-3-jiri@resnulli.us> <519cfd86-dcc8-9dc4-1929-71ea1084689b@gmail.com> <20190415054104.GD24144@nanopsycho.orion> From: David Ahern Message-ID: <2e024c38-0368-1dae-4be5-07b34d596a58@gmail.com> Date: Mon, 15 Apr 2019 09:07:04 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190415054104.GD24144@nanopsycho.orion> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/14/19 11:41 PM, Jiri Pirko wrote: > Mon, Apr 15, 2019 at 04:24:24AM CEST, dsahern@gmail.com wrote: >> On 4/13/19 10:20 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Currently there is one devlink instance created per network namespace. >>> That is quite odd considering the fact that devlink instance should >>> represent an ASIC. The following patches are going to move the devlink >>> instance even more down to a bus device, but until then, have one >>> devlink instance per netdevsim instance. Struct nsim_devlink is >>> introduced to hold fib setting. >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> drivers/net/netdevsim/devlink.c | 179 +++++++++++------------------- >>> drivers/net/netdevsim/fib.c | 103 +++++++---------- >>> drivers/net/netdevsim/netdev.c | 27 ++--- >>> drivers/net/netdevsim/netdevsim.h | 18 +-- >>> 4 files changed, 125 insertions(+), 202 deletions(-) >> >> you are making a lot of changes to how fib events are handled and not >> explaining what you are doing. > > They are handled in the exact same way. This is just about devlink > instance. Will add that to description. > Data is currently stored as a net_generic. You are changing that. The changelog should state that.