From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <keescook@chromium.org>, <netdev@vger.kernel.org>,
<linux-hardening@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays
Date: Fri, 4 Aug 2023 11:07:14 -0700 [thread overview]
Message-ID: <2e163fb1-492e-8a1f-9df1-270c652e9799@intel.com> (raw)
In-Reply-To: <88dce445-180c-72d9-c7a5-f0a18a18c747@intel.com>
On 8/4/2023 9:38 AM, Alexander Lobakin wrote:
> From: Alexander Lobakin <aleksander.lobakin@intel.com>
> Date: Fri, 28 Jul 2023 17:52:04 +0200
>
>> 6.5-rc1 started spitting warning splats when composing virtchnl
>> messages, precisely on virtchnl_rss_key and virtchnl_lut:
>>
>> [ 84.167709] memcpy: detected field-spanning write (size 52) of single
>> field "vrk->key" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1095
>> (size 1)
>> [ 84.169915] WARNING: CPU: 3 PID: 11 at drivers/net/ethernet/intel/
>> iavf/iavf_virtchnl.c:1095 iavf_set_rss_key+0x123/0x140 [iavf]
>
> [...]
>
>> .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +-
>> drivers/net/ethernet/intel/iavf/iavf.h | 6 +-
>> drivers/net/ethernet/intel/iavf/iavf_client.c | 4 +-
>> drivers/net/ethernet/intel/iavf/iavf_client.h | 2 +-
>> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 75 +++++------
>> drivers/net/ethernet/intel/ice/ice_virtchnl.c | 2 +-
>> include/linux/avf/virtchnl.h | 127 +++++++++++-------
>> 7 files changed, 124 insertions(+), 101 deletions(-)
>>
>
> Tony, could you please take it via your next tree? I'd like the
> validation to make sure more different host <-> guest pairs work.
>
> (with Kees' tags, assuming he reviewed and approved the whole series, I
> asked about #2 already)
>
> Thanks,
> Olek
Ok, will apply it today. For the future if you want it through IWL, can
you tag it with the iwl-* target (and have IWL in the To)? Since this
had 'net-next' and was 'To' netdev maintainers, I took it that you
wanted it taken through netdev.
Thanks,
Tony
next prev parent reply other threads:[~2023-08-04 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 15:52 [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays Alexander Lobakin
2023-07-28 15:52 ` [PATCH net-next 1/3] virtchnl: fix fake 1-elem arrays in structs allocated as `nents + 1` - 1 Alexander Lobakin
2023-07-28 22:43 ` Kees Cook
2023-08-01 13:08 ` Alexander Lobakin
2023-08-04 8:27 ` Kees Cook
2023-08-04 15:42 ` Alexander Lobakin
2023-08-04 17:29 ` Kees Cook
2023-08-04 17:33 ` Alexander Lobakin
2023-08-16 12:48 ` [Intel-wired-lan] " Romanowski, Rafal
2023-07-28 15:52 ` [PATCH net-next 2/3] virtchnl: fix fake 1-elem arrays in structures allocated as `nents + 1` Alexander Lobakin
2023-08-04 8:29 ` Kees Cook
2023-08-16 12:49 ` [Intel-wired-lan] " Romanowski, Rafal
2023-07-28 15:52 ` [PATCH net-next 3/3] virtchnl: fix fake 1-elem arrays for structures allocated as `nents` Alexander Lobakin
2023-08-04 8:30 ` Kees Cook
2023-08-16 12:51 ` [Intel-wired-lan] " Romanowski, Rafal
2023-08-03 15:55 ` [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays Alexander Lobakin
2023-08-04 16:38 ` Alexander Lobakin
2023-08-04 18:07 ` Tony Nguyen [this message]
2023-08-04 18:09 ` Alexander Lobakin
2023-08-16 12:48 ` [Intel-wired-lan] " Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e163fb1-492e-8a1f-9df1-270c652e9799@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).