From: Edward Cree <ecree.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, petrm@nvidia.com,
willemb@google.com, sdf@fomichev.me,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: exit cleanly on SIGTERM / timeout
Date: Wed, 30 Apr 2025 19:03:34 +0100 [thread overview]
Message-ID: <2e16fc73-e272-4277-b232-b912c84f5d4b@gmail.com> (raw)
In-Reply-To: <20250429170804.2649622-1-kuba@kernel.org>
On 29/04/2025 18:08, Jakub Kicinski wrote:
> +class KsftTerminate(KeyboardInterrupt):
> + pass
...
> @@ -229,11 +249,12 @@ KSFT_DISRUPTIVE = True
> cnt_key = 'xfail'
> except BaseException as e:
> stop |= isinstance(e, KeyboardInterrupt)
> + stop |= isinstance(e, KsftTerminate)
The first isinstance() will return True for a KsftTerminate as it's a
subclass of KeyboardInterrupt, and thus the second line isn't needed.
next prev parent reply other threads:[~2025-04-30 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 17:08 [PATCH net-next v2] selftests: net: exit cleanly on SIGTERM / timeout Jakub Kicinski
2025-04-29 17:34 ` Willem de Bruijn
2025-04-30 18:03 ` Edward Cree [this message]
2025-05-02 13:05 ` Paolo Abeni
2025-05-03 1:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e16fc73-e272-4277-b232-b912c84f5d4b@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).