netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	"Ertman, David M" <david.m.ertman@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [iwl-next v4 1/1] iidc/ice/irdma: Update IDC to support multiple consumers
Date: Tue, 18 Mar 2025 12:45:48 -0700	[thread overview]
Message-ID: <2e29a3f3-1c74-461a-a7ae-efe6c429fa1f@intel.com> (raw)
In-Reply-To: <20250318172026.GA9311@nvidia.com>



On 3/18/2025 10:20 AM, Jason Gunthorpe wrote:
> On Tue, Mar 18, 2025 at 10:01:36AM -0700, Samudrala, Sridhar wrote:
> 
>> Yes. Today irdma uses exported symbols from i40e and ice and loading irdma
>> results in both modules to be loaded even when only type of NIC is present
>> on a system. This series is trying to remove that dependency by using
>> callbacks.
> 
> If you really have two different core drivers that can provide the
> same API then I think you are stuck with function pointers :\
> 
> It is really weird though, why are their two core drivers that can
> provide the same API? Is this because intel keeps rewriting their
> driver stack every few years?

This is a known issue due to HW/FW interface changes across multiple 
generations of the NICs forcing us to go with separate core drivers.

We are working with HW/FW teams to avoid this in future and going 
forward we expect to have idpf/ixd as the 2 drivers (idpf providing the 
data path functionality and ixd as the control/data/switchdev port-rep 
driver) for all our future FNICs/IPUs.

Leon, Could you approve the callbacks approach considering that irdma 
needs to support multiple intel nic core drivers. We would really 
appreciate it.

-SridharW

  reply	other threads:[~2025-03-18 19:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25  5:04 [iwl-next v4 0/1] Add RDMA support for Intel IPU E2000 (GEN3) Tatyana Nikolova
2025-02-25  5:04 ` [iwl-next v4 1/1] iidc/ice/irdma: Update IDC to support multiple consumers Tatyana Nikolova
2025-02-25  7:55   ` Leon Romanovsky
2025-02-26 17:36     ` Ertman, David M
2025-02-26 18:50       ` Leon Romanovsky
2025-02-26 23:01         ` Ertman, David M
2025-03-02  8:26           ` Leon Romanovsky
2025-03-13 23:38             ` [Intel-wired-lan] " Samudrala, Sridhar
2025-03-14 18:12               ` Leon Romanovsky
2025-03-15  1:18                 ` Samudrala, Sridhar
2025-03-17 11:57                   ` Leon Romanovsky
2025-03-18 17:01                     ` Samudrala, Sridhar
2025-03-18 17:20                       ` Jason Gunthorpe
2025-03-18 19:45                         ` Samudrala, Sridhar [this message]
2025-03-19  8:04                           ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e29a3f3-1c74-461a-a7ae-efe6c429fa1f@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=david.m.ertman@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jgg@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tatyana.e.nikolova@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).