From: Paolo Abeni <pabeni@redhat.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] xfrm: hold device only for the asynchronous decryption
Date: Thu, 24 Jul 2025 15:18:12 +0200 [thread overview]
Message-ID: <2e49ee3e-bd77-410b-b367-d16e688d8a40@redhat.com> (raw)
In-Reply-To: <20250723080402.3439619-2-steffen.klassert@secunet.com>
On 7/23/25 10:03 AM, Steffen Klassert wrote:
> @@ -649,18 +650,18 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
> XFRM_SKB_CB(skb)->seq.input.low = seq;
> XFRM_SKB_CB(skb)->seq.input.hi = seq_hi;
>
> - dev_hold(skb->dev);
> -
> - if (crypto_done)
> + if (crypto_done) {
> nexthdr = x->type_offload->input_tail(x, skb);
> - else
> + } else {
> + dev_hold(skb->dev);
Side note for a possible follow-up: plain dev_hold()/dev_put() usage
should be replaced by the tracker-enabled variant
(netdev_hold()/netdev_put())
/P
next prev parent reply other threads:[~2025-07-24 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:03 [PATCH 0/3] pull request (net-next): ipsec-next 2025-07-23 Steffen Klassert
2025-07-23 8:03 ` [PATCH 1/3] xfrm: hold device only for the asynchronous decryption Steffen Klassert
2025-07-24 13:18 ` Paolo Abeni [this message]
2025-07-24 13:30 ` patchwork-bot+netdevbpf
2025-07-23 8:03 ` [PATCH 2/3] xfrm: Duplicate SPI Handling Steffen Klassert
2025-07-23 8:03 ` [PATCH 3/3] xfrm: Skip redundant statistics update for crypto offload Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e49ee3e-bd77-410b-b367-d16e688d8a40@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox