* Re: [PATCH v3 01/19] dt-bindings: ARM: MediaTek: Add new document bindings of MT8188 clock
[not found] ` <20221230073357.18503-2-Garmin.Chang@mediatek.com>
@ 2022-12-30 10:41 ` Krzysztof Kozlowski
2023-01-09 10:14 ` Garmin Chang (張家銘)
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-30 10:41 UTC (permalink / raw)
To: Garmin.Chang, Matthias Brugger, Rob Herring, Krzysztof Kozlowski,
Michael Turquette, Stephen Boyd, Richard Cochran
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, linux-clk, netdev
On 30/12/2022 08:33, Garmin.Chang wrote:
> Add the new binding documentation for system clock
> and functional clock on MediaTek MT8188.
>
Subject: drop second, redundant "document bindings of".
> Signed-off-by: Garmin.Chang <Garmin.Chang@mediatek.com>
> ---
> .../arm/mediatek/mediatek,mt8188-clock.yaml | 71 ++
> .../mediatek/mediatek,mt8188-sys-clock.yaml | 55 ++
> .../dt-bindings/clock/mediatek,mt8188-clk.h | 733 ++++++++++++++++++
> 3 files changed, 859 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-clock.yaml
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-sys-clock.yaml
> create mode 100644 include/dt-bindings/clock/mediatek,mt8188-clk.h
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-clock.yaml
> new file mode 100644
> index 000000000000..6654cead71f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-clock.yaml
Clock controllers do not go to arm but to clock. It's so suprising
directory that I missed to notice it in v1... Why putting it in some
totally irrelevant directory?
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/mediatek/mediatek,mt8188-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Functional Clock Controller for MT8188
> +
> +maintainers:
> + - Garmin Chang <garmin.chang@mediatek.com>
> +
> +description: |
> + The clock architecture in MediaTek like below
> + PLLs -->
> + dividers -->
> + muxes
> + -->
> + clock gate
> +
> + The devices provide clock gate control in different IP blocks.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8188-adsp-audio26m
> + - mediatek,mt8188-imp-iic-wrap-c
> + - mediatek,mt8188-imp-iic-wrap-en
> + - mediatek,mt8188-imp-iic-wrap-w
> + - mediatek,mt8188-mfgcfg
> + - mediatek,mt8188-vppsys0
> + - mediatek,mt8188-wpesys
> + - mediatek,mt8188-wpesys-vpp0
> + - mediatek,mt8188-vppsys1
> + - mediatek,mt8188-imgsys
> + - mediatek,mt8188-imgsys-wpe1
> + - mediatek,mt8188-imgsys-wpe2
> + - mediatek,mt8188-imgsys-wpe3
> + - mediatek,mt8188-imgsys1-dip-top
> + - mediatek,mt8188-imgsys1-dip-nr
> + - mediatek,mt8188-ipesys
> + - mediatek,mt8188-camsys
> + - mediatek,mt8188-camsys-rawa
> + - mediatek,mt8188-camsys-yuva
> + - mediatek,mt8188-camsys-rawb
> + - mediatek,mt8188-camsys-yuvb
> + - mediatek,mt8188-ccusys
> + - mediatek,mt8188-vdecsys-soc
> + - mediatek,mt8188-vdecsys
> + - mediatek,mt8188-vencsys
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + clock-controller@11283000 {
> + compatible = "mediatek,mt8188-imp-iic-wrap-c";
> + reg = <0x11283000 0x1000>;
> + #clock-cells = <1>;
> + };
> +
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-sys-clock.yaml
> new file mode 100644
> index 000000000000..2b28df1ff895
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-sys-clock.yaml
Wrong directory.
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/mediatek/mediatek,mt8188-sys-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek System Clock Controller for MT8188
> +
> +maintainers:
> + - Garmin Chang <garmin.chang@mediatek.com>
> +
> +description: |
> + The clock architecture in MediaTek like below
> + PLLs -->
> + dividers -->
> + muxes
> + -->
> + clock gate
> +
> + The apmixedsys provides most of PLLs which generated from SoC 26m.
> + The topckgen provides dividers and muxes which provide the clock source to other IP blocks.
> + The infracfg_ao provides clock gate in peripheral and infrastructure IP blocks.
> + The mcusys provides mux control to select the clock source in AP MCU.
> + The device nodes also provide the system control capacity for configuration.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - mediatek,mt8188-topckgen
> + - mediatek,mt8188-infracfg-ao
> + - mediatek,mt8188-apmixedsys
> + - mediatek,mt8188-pericfg-ao
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + '#clock-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + syscon@10000000 {
clock-controller
> + compatible = "mediatek,mt8188-topckgen", "syscon";
> + reg = <0x10000000 0x1000>;
> + #clock-cells = <1>;
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 01/19] dt-bindings: ARM: MediaTek: Add new document bindings of MT8188 clock
2022-12-30 10:41 ` [PATCH v3 01/19] dt-bindings: ARM: MediaTek: Add new document bindings of MT8188 clock Krzysztof Kozlowski
@ 2023-01-09 10:14 ` Garmin Chang (張家銘)
2023-01-09 10:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Garmin Chang (張家銘) @ 2023-01-09 10:14 UTC (permalink / raw)
To: matthias.bgg@gmail.com, sboyd@kernel.org,
krzysztof.kozlowski@linaro.org, mturquette@baylibre.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
richardcochran@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org, linux-clk@vger.kernel.org,
Project_Global_Chrome_Upstream_Group, devicetree@vger.kernel.org
On Fri, 2022-12-30 at 11:41 +0100, Krzysztof Kozlowski wrote:
> On 30/12/2022 08:33, Garmin.Chang wrote:
> > Add the new binding documentation for system clock
> > and functional clock on MediaTek MT8188.
> >
>
> Subject: drop second, redundant "document bindings of".
>
Hi Krzysztof,
Thank you for your suggestions.
OK. I'll remove it in v4.
> > Signed-off-by: Garmin.Chang <Garmin.Chang@mediatek.com>
> > ---
> > .../arm/mediatek/mediatek,mt8188-clock.yaml | 71 ++
> > .../mediatek/mediatek,mt8188-sys-clock.yaml | 55 ++
> > .../dt-bindings/clock/mediatek,mt8188-clk.h | 733
> > ++++++++++++++++++
> > 3 files changed, 859 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > clock.yaml
> > create mode 100644
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-sys-
> > clock.yaml
> > create mode 100644 include/dt-bindings/clock/mediatek,mt8188-clk.h
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > clock.yaml
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > clock.yaml
> > new file mode 100644
> > index 000000000000..6654cead71f6
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > clock.yaml
>
> Clock controllers do not go to arm but to clock. It's so suprising
> directory that I missed to notice it in v1... Why putting it in some
> totally irrelevant directory?
>
Do you mean move to the path below ?
Documentation\devicetree\bindings\clock
If yes, I will change it in v4.
>
> > @@ -0,0 +1,71 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/arm/mediatek/mediatek,mt8188-clock.yaml*__;Iw!!CTRNKA9wMg0ARbw!k6TPgiSrp00ShwE2Y9vMUkqWmyDNXd1bN0X4IvM6MyyHj-YDg7q-2_LnG8CTdYdtmQrVLIi8Y1z_kHzKzw6xIr02lel3z8Y$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!k6TPgiSrp00ShwE2Y9vMUkqWmyDNXd1bN0X4IvM6MyyHj-YDg7q-2_LnG8CTdYdtmQrVLIi8Y1z_kHzKzw6xIr02_N--doc$
> >
> > +
> > +title: MediaTek Functional Clock Controller for MT8188
> > +
> > +maintainers:
> > + - Garmin Chang <garmin.chang@mediatek.com>
> > +
> > +description: |
> > + The clock architecture in MediaTek like below
> > + PLLs -->
> > + dividers -->
> > + muxes
> > + -->
> > + clock gate
> > +
> > + The devices provide clock gate control in different IP blocks.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8188-adsp-audio26m
> > + - mediatek,mt8188-imp-iic-wrap-c
> > + - mediatek,mt8188-imp-iic-wrap-en
> > + - mediatek,mt8188-imp-iic-wrap-w
> > + - mediatek,mt8188-mfgcfg
> > + - mediatek,mt8188-vppsys0
> > + - mediatek,mt8188-wpesys
> > + - mediatek,mt8188-wpesys-vpp0
> > + - mediatek,mt8188-vppsys1
> > + - mediatek,mt8188-imgsys
> > + - mediatek,mt8188-imgsys-wpe1
> > + - mediatek,mt8188-imgsys-wpe2
> > + - mediatek,mt8188-imgsys-wpe3
> > + - mediatek,mt8188-imgsys1-dip-top
> > + - mediatek,mt8188-imgsys1-dip-nr
> > + - mediatek,mt8188-ipesys
> > + - mediatek,mt8188-camsys
> > + - mediatek,mt8188-camsys-rawa
> > + - mediatek,mt8188-camsys-yuva
> > + - mediatek,mt8188-camsys-rawb
> > + - mediatek,mt8188-camsys-yuvb
> > + - mediatek,mt8188-ccusys
> > + - mediatek,mt8188-vdecsys-soc
> > + - mediatek,mt8188-vdecsys
> > + - mediatek,mt8188-vencsys
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#clock-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + clock-controller@11283000 {
> > + compatible = "mediatek,mt8188-imp-iic-wrap-c";
> > + reg = <0x11283000 0x1000>;
> > + #clock-cells = <1>;
> > + };
> > +
> > diff --git
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > sys-clock.yaml
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > sys-clock.yaml
> > new file mode 100644
> > index 000000000000..2b28df1ff895
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
> > sys-clock.yaml
>
> Wrong directory.
> follow the answer above.
>
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/arm/mediatek/mediatek,mt8188-sys-clock.yaml*__;Iw!!CTRNKA9wMg0ARbw!k6TPgiSrp00ShwE2Y9vMUkqWmyDNXd1bN0X4IvM6MyyHj-YDg7q-2_LnG8CTdYdtmQrVLIi8Y1z_kHzKzw6xIr02P0KcerI$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!k6TPgiSrp00ShwE2Y9vMUkqWmyDNXd1bN0X4IvM6MyyHj-YDg7q-2_LnG8CTdYdtmQrVLIi8Y1z_kHzKzw6xIr02_N--doc$
> >
> > +
> > +title: MediaTek System Clock Controller for MT8188
> > +
> > +maintainers:
> > + - Garmin Chang <garmin.chang@mediatek.com>
> > +
> > +description: |
> > + The clock architecture in MediaTek like below
> > + PLLs -->
> > + dividers -->
> > + muxes
> > + -->
> > + clock gate
> > +
> > + The apmixedsys provides most of PLLs which generated from SoC
> > 26m.
> > + The topckgen provides dividers and muxes which provide the clock
> > source to other IP blocks.
> > + The infracfg_ao provides clock gate in peripheral and
> > infrastructure IP blocks.
> > + The mcusys provides mux control to select the clock source in AP
> > MCU.
> > + The device nodes also provide the system control capacity for
> > configuration.
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - mediatek,mt8188-topckgen
> > + - mediatek,mt8188-infracfg-ao
> > + - mediatek,mt8188-apmixedsys
> > + - mediatek,mt8188-pericfg-ao
> > + - const: syscon
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#clock-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + syscon@10000000 {
>
> clock-controller
OK. I'll use clock-controller in v4.
>
> > + compatible = "mediatek,mt8188-topckgen", "syscon";
> > + reg = <0x10000000 0x1000>;
> > + #clock-cells = <1>;
>
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 01/19] dt-bindings: ARM: MediaTek: Add new document bindings of MT8188 clock
2023-01-09 10:14 ` Garmin Chang (張家銘)
@ 2023-01-09 10:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-09 10:31 UTC (permalink / raw)
To: Garmin Chang (張家銘), matthias.bgg@gmail.com,
sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org, linux-clk@vger.kernel.org,
Project_Global_Chrome_Upstream_Group, devicetree@vger.kernel.org
On 09/01/2023 11:14, Garmin Chang (張家銘) wrote:
>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8188-
>>> clock.yaml
>>
>> Clock controllers do not go to arm but to clock. It's so suprising
>> directory that I missed to notice it in v1... Why putting it in some
>> totally irrelevant directory?
>>
> Do you mean move to the path below ?
> Documentation\devicetree\bindings\clock
>
> If yes, I will change it in v4.
Yes.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-09 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221230073357.18503-1-Garmin.Chang@mediatek.com>
[not found] ` <20221230073357.18503-2-Garmin.Chang@mediatek.com>
2022-12-30 10:41 ` [PATCH v3 01/19] dt-bindings: ARM: MediaTek: Add new document bindings of MT8188 clock Krzysztof Kozlowski
2023-01-09 10:14 ` Garmin Chang (張家銘)
2023-01-09 10:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).