From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Jacob Keller <jacob.e.keller@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Wander Lairson Costa" <wander@redhat.com>
Cc: <tglx@linutronix.de>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Simon Horman <horms@kernel.org>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT"
<linux-rt-devel@lists.linux.dev>
Subject: Re: [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"
Date: Tue, 12 Nov 2024 15:52:34 +0100 [thread overview]
Message-ID: <2e6cea97-0ebf-4767-b014-680a0502e1f9@intel.com> (raw)
In-Reply-To: <20241111125345.T10WlDUG@linutronix.de>
On 11/11/24 13:53, Sebastian Andrzej Siewior wrote:
> On 2024-11-08 15:00:48 [-0800], Jacob Keller wrote:
>>
>>
>> On 11/8/2024 4:28 AM, Sebastian Andrzej Siewior wrote:
>>> On 2024-11-08 13:20:28 [+0100], Przemek Kitszel wrote:
>>>> I don't like to slow things down, but it would be great to have a Link:
>>>> to the report, and the (minified) splat attached.
>>>
>>> I don't have a splat, I just reviewed the original patch. Please do
>>> delay this.
>
> this clearly lacks a `not'
sorry for the slowdown then,
Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
>>> Sebastian
>>
>> It will definitely splat on RT kernels at some point, if there is a
>> spinlock.
>
> exactly my point.
still would be great to add some basic RT tests in our VAL,
but it's unrelated to this patch
next prev parent reply other threads:[~2024-11-12 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 11:14 [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other" Wander Lairson Costa
2024-11-08 7:20 ` Sebastian Andrzej Siewior
2024-11-08 11:44 ` Wander Lairson Costa
2024-11-08 12:20 ` Przemek Kitszel
2024-11-08 12:28 ` Sebastian Andrzej Siewior
2024-11-08 15:02 ` Przemek Kitszel
2024-11-08 23:00 ` Jacob Keller
2024-11-11 12:53 ` Sebastian Andrzej Siewior
2024-11-12 14:52 ` Przemek Kitszel [this message]
2024-11-12 15:04 ` Jakub Kicinski
2024-11-12 15:56 ` Przemek Kitszel
2024-11-13 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e6cea97-0ebf-4767-b014-680a0502e1f9@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).