From: "lipeng (Y)" <lipeng321@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <huangguangbin2@huawei.com>
Subject: Re: [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue
Date: Fri, 18 Jun 2021 08:45:22 +0800 [thread overview]
Message-ID: <2ea3967f-b4e4-323b-bf65-aac108c6d27f@huawei.com> (raw)
In-Reply-To: <YMt4ZMuPfjeesnRK@lunn.ch>
在 2021/6/18 0:29, Andrew Lunn 写道:
>> @@ -152,12 +146,12 @@ static int hostess_close(struct net_device *d)
>> static int hostess_ioctl(struct net_device *d, struct ifreq *ifr, int cmd)
>> {
>> /* struct z8530_dev *sv11=dev_to_sv(d);
>> - z8530_ioctl(d,&sv11->chanA,ifr,cmd) */
>> + * z8530_ioctl(d,&sv11->chanA,ifr,cmd)
>> + */
>> return hdlc_ioctl(d, ifr, cmd);
>> }
> That looks more like dead code than anything else. I would suggest you
> do a git blame to see if there is anything interesting about this, and
> if not, remove it.
>
> Andrew
> .
Hi, Andrew
It's dead code, will remove it.
Thanks for your advice.
Peng Li
next prev parent reply other threads:[~2021-06-18 0:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 14:53 [PATCH net-next 0/6] net: hostess_sv11: clean up some code style issues Peng Li
2021-06-17 14:53 ` [PATCH net-next 1/6] net: hostess_sv11: fix the code style issue about "foo* bar" Peng Li
2021-06-17 14:53 ` [PATCH net-next 2/6] net: hostess_sv11: move out assignment in if condition Peng Li
2021-06-17 14:53 ` [PATCH net-next 3/6] net: hostess_sv11: remove trailing whitespace Peng Li
2021-06-17 14:53 ` [PATCH net-next 4/6] net: hostess_sv11: fix the code style issue about switch and case Peng Li
2021-06-17 14:53 ` [PATCH net-next 5/6] net: hostess_sv11: fix the comments style issue Peng Li
2021-06-17 16:29 ` Andrew Lunn
2021-06-18 0:45 ` lipeng (Y) [this message]
2021-06-17 14:53 ` [PATCH net-next 6/6] net: hostess_sv11: fix the alignment issue Peng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea3967f-b4e4-323b-bf65-aac108c6d27f@huawei.com \
--to=lipeng321@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).