From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A3DC282D8 for ; Wed, 30 Jan 2019 22:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BD82218AF for ; Wed, 30 Jan 2019 22:54:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731742AbfA3Wyw convert rfc822-to-8bit (ORCPT ); Wed, 30 Jan 2019 17:54:52 -0500 Received: from belmont79srvr.owm.bell.net ([184.150.200.79]:53042 "EHLO mtlfep01.bell.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731013AbfA3Wyw (ORCPT ); Wed, 30 Jan 2019 17:54:52 -0500 Received: from bell.net mtlfep02 184.150.200.30 by mtlfep02.bell.net with ESMTP id <20190130222453.YTHV27401.mtlfep02.bell.net@mtlspm02.bell.net> for ; Wed, 30 Jan 2019 17:24:53 -0500 Received: from [192.168.0.138] (really [64.231.92.241]) by mtlspm02.bell.net with ESMTP id <20190130222453.SMPR26679.mtlspm02.bell.net@[192.168.0.138]>; Wed, 30 Jan 2019 17:24:53 -0500 To: Andrew Lunn Cc: Russell King , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org References: <49eec816-9238-c893-0860-602aa8965515@bell.net> <20190122202834.GB12052@lunn.ch> <09fce2e0-9dd2-ea30-7e7d-72f04eede68b@bell.net> <20190122223649.GD3634@lunn.ch> <20190123002240.GF3634@lunn.ch> <20190130172818.GJ21904@lunn.ch> From: John David Anglin Openpgp: preference=signencrypt Subject: Re: net: phylink: dsa: mv88e6xxx: flaky link detection on switch ports with internal PHYs Message-ID: <2ea9fd81-f92d-9505-dd0b-bdd0f67d8ce7@bell.net> Date: Wed, 30 Jan 2019 17:24:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190130172818.GJ21904@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Content-Language: en-US X-Cloudmark-Analysis: v=2.2 cv=O6bWhF1W c=1 sm=0 tr=0 a=jJmVOGxBrKxWvcjqaG+oVg==:17 a=IkcTkHD0fZMA:10 a=3JhidrIBZZsA:10 a=FBHGMhGWAAAA:8 a=__ZkxkO8cEhu1FiUO78A:9 a=QEXdDO2ut3YA:10 a=9gvnlMMaQFpL9xblJ6ne:22 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019-01-30 12:28 p.m., Andrew Lunn wrote: > You need active low interrupts. Without it, i think you are always > going to have race conditions which will cause interrupts to get > stuck/lost. I don't know if this is a hardware limitation or not, but currently the armada 37xx doesn't support level interrupts: [    4.013280] genirq: Setting trigger mode 8 for irq 44 failed (armada_37xx_irq_set_type+0x0/0x158) [    4.014075] mv88e6085: probe of d0032004.mdio-mii:01 failed with error -22 The function armada_37xx_irq_set_type() only supports edge interrupts. On the plus side, DTC no longer objects to level interrupts on southbridge. Dave -- John David Anglin dave.anglin@bell.net