netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: soukjin.bae@samsung.com,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"lorenzo@google.com" <lorenzo@google.com>
Cc: 유금환 <geumhwan.yu@samsung.com>
Subject: Re: FW: [Resource Leak] Suggesting patch for tcp_close
Date: Tue, 27 Nov 2018 20:58:19 -0800	[thread overview]
Message-ID: <2eb8a518-1a84-5782-b0e2-c78fe88dfe4b@gmail.com> (raw)
In-Reply-To: <a2dd1915-ce29-d892-c43a-c43555f596b7@gmail.com>



On 11/27/2018 08:57 PM, Eric Dumazet wrote:
> 
> 
> On 11/27/2018 05:09 PM, 배석진 wrote:
>> Hello all,
>>
>> nobody concern about this? minor problem? :(
>> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK.
> 
> These sessions should have a timer, and eventually disappear.
> 
> Do you have a test to demonstrate the issue ?
> 
> I know Lorenzo wrote tests, so presumably new tests are needed.

BTW your patch title is confusing.
You are changing tcp_abort(), not tcp_close()

  reply	other threads:[~2018-11-28 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p8>
2018-11-23  7:22 ` Suggesting patch for tcp_close 배석진
     [not found]   ` <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p7>
2018-11-28  1:09     ` FW: [Resource Leak] " 배석진
2018-11-28  4:57       ` Eric Dumazet
2018-11-28  4:58         ` Eric Dumazet [this message]
     [not found]       ` <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p1>
2018-11-28  6:17         ` 배석진
2018-11-28  7:36           ` (2) " Lorenzo Colitti
     [not found]           ` <CGME20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p6>
2018-11-28  8:49             ` 배석진
2018-11-28 14:40           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eb8a518-1a84-5782-b0e2-c78fe88dfe4b@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=geumhwan.yu@samsung.com \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soukjin.bae@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).