From: Tom Lendacky <thomas.lendacky@amd.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: andrew@lunn.ch, ecree@solarflare.com, mkubecek@suse.cz,
benve@cisco.com, _govind@gmx.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
snelson@pensando.io, yisen.zhuang@huawei.com,
salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com,
jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com,
michael.chan@broadcom.com, saeedm@mellanox.com, leon@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 02/12] xgbe: let core reject the unsupported coalescing parameters
Date: Thu, 5 Mar 2020 08:30:24 -0600 [thread overview]
Message-ID: <2ec3b324-bb64-50ed-8a3e-848d648fb35b@amd.com> (raw)
In-Reply-To: <20200305051542.991898-3-kuba@kernel.org>
On 3/4/20 11:15 PM, Jakub Kicinski wrote:
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
>
> This driver correctly rejects all unsupported parameters.
> We are only losing the error print.
>
> v3: adjust commit message for new error code and member name
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 26 ++------------------
> 1 file changed, 2 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> index b23c8ee24ee3..61f39a0e04f9 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> @@ -450,30 +450,6 @@ static int xgbe_set_coalesce(struct net_device *netdev,
> unsigned int rx_frames, rx_riwt, rx_usecs;
> unsigned int tx_frames;
>
> - /* Check for not supported parameters */
> - if ((ec->rx_coalesce_usecs_irq) ||
> - (ec->rx_max_coalesced_frames_irq) ||
> - (ec->tx_coalesce_usecs) ||
> - (ec->tx_coalesce_usecs_irq) ||
> - (ec->tx_max_coalesced_frames_irq) ||
> - (ec->stats_block_coalesce_usecs) ||
> - (ec->use_adaptive_rx_coalesce) ||
> - (ec->use_adaptive_tx_coalesce) ||
> - (ec->pkt_rate_low) ||
> - (ec->rx_coalesce_usecs_low) ||
> - (ec->rx_max_coalesced_frames_low) ||
> - (ec->tx_coalesce_usecs_low) ||
> - (ec->tx_max_coalesced_frames_low) ||
> - (ec->pkt_rate_high) ||
> - (ec->rx_coalesce_usecs_high) ||
> - (ec->rx_max_coalesced_frames_high) ||
> - (ec->tx_coalesce_usecs_high) ||
> - (ec->tx_max_coalesced_frames_high) ||
> - (ec->rate_sample_interval)) {
> - netdev_err(netdev, "unsupported coalescing parameter\n");
> - return -EOPNOTSUPP;
> - }
> -
> rx_riwt = hw_if->usec_to_riwt(pdata, ec->rx_coalesce_usecs);
> rx_usecs = ec->rx_coalesce_usecs;
> rx_frames = ec->rx_max_coalesced_frames;
> @@ -837,6 +813,8 @@ static int xgbe_set_channels(struct net_device *netdev,
> }
>
> static const struct ethtool_ops xgbe_ethtool_ops = {
> + .supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS |
> + ETHTOOL_COALESCE_MAX_FRAMES,
> .get_drvinfo = xgbe_get_drvinfo,
> .get_msglevel = xgbe_get_msglevel,
> .set_msglevel = xgbe_set_msglevel,
>
next prev parent reply other threads:[~2020-03-05 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 5:15 [PATCH net-next v3 00/12] ethtool: consolidate parameter checking for irq coalescing Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters Jakub Kicinski
2020-03-05 13:13 ` Michal Kubecek
2020-03-05 13:27 ` Andrew Lunn
2020-03-05 16:24 ` Alexander Duyck
2020-03-05 5:15 ` [PATCH net-next v3 02/12] xgbe: let core reject the unsupported " Jakub Kicinski
2020-03-05 14:30 ` Tom Lendacky [this message]
2020-03-05 5:15 ` [PATCH net-next v3 03/12] enic: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 04/12] stmmac: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 05/12] nfp: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 06/12] ionic: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 07/12] hisilicon: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 08/12] ice: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 09/12] bnxt: reject unsupported coalescing params Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 10/12] mlx5: " Jakub Kicinski
2020-03-05 8:14 ` Saeed Mahameed
2020-03-05 5:15 ` [PATCH net-next v3 11/12] e1000e: " Jakub Kicinski
2020-03-05 5:15 ` [PATCH net-next v3 12/12] virtio_net: " Jakub Kicinski
2020-03-05 20:17 ` [PATCH net-next v3 00/12] ethtool: consolidate parameter checking for irq coalescing David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec3b324-bb64-50ed-8a3e-848d648fb35b@amd.com \
--to=thomas.lendacky@amd.com \
--cc=_govind@gmx.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedm@mellanox.com \
--cc=salil.mehta@huawei.com \
--cc=snelson@pensando.io \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).