From: Alexandra Winter <wintera@linux.ibm.com>
To: sashiko-reviews@lists.linux.dev, Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net v2] net/iucv: descend into net/iucv independently of IUCV
Date: Mon, 17 Aug 2026 17:03:17 +0200 [thread overview]
Message-ID: <2edbc943-1485-4cfd-80a6-165271463dc0@linux.ibm.com> (raw)
In-Reply-To: <4fb902b2-bd5e-48b0-aca0-07e51a80d8c7@linux.ibm.com>
On 17.08.26 14:06, Alexandra Winter wrote:
>
>
> On 16.08.26 15:55, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>>
>> New issues:
>> - [High] Unconditional descent into net/iucv/ causes a vmlinux linker error when CONFIG_AFIUCV=y and CONFIG_IUCV=m.
>
> @Pengpeng Hou,
> if it easier, you can also fix this issue by making CONFIG_AFIUCV depend on CONFIG_IUCV.
> I see no practical scenario where we would want AFIUCV without IUCV.
>
And I agree with Sashiko. I did not verify this combination with your initial RFC, sorry.
So I propose to depend AFIUCV on IUCV instead of your patch.
Do you want to send such a patch, or do you want me to do that?
prev parent reply other threads:[~2026-08-17 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 13:54 [PATCH net v2] net/iucv: descend into net/iucv independently of IUCV Pengpeng Hou
[not found] ` <20260816135517.816271F000E9@smtp.kernel.org>
[not found] ` <4fb902b2-bd5e-48b0-aca0-07e51a80d8c7@linux.ibm.com>
2026-08-17 15:03 ` Alexandra Winter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2edbc943-1485-4cfd-80a6-165271463dc0@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengpeng@iscas.ac.cn \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox