From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [patch net-next] net: 8021q: move vlan offload registrations into vlan_core Date: Wed, 14 Nov 2018 22:39:58 -0800 Message-ID: <2ee1a172-9c70-61a9-8f8d-019db6f8e4d1@gmail.com> References: <20181113222248.2773-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, michaelsh86@gmail.com, ktkhai@virtuozzo.com, sbrivio@redhat.com, sd@queasysnail.net, xiyou.wangcong@gmail.com, dcaratti@redhat.com, weiyongjun1@huawei.com, ivan.khoronzhuk@linaro.org, grygorii.strashko@ti.com, tariqt@mellanox.com, makita.toshiaki@lab.ntt.co.jp, mirq-linux@rere.qmqm.pl, mlxsw@mellanox.com To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mail-it1-f172.google.com ([209.85.166.172]:37294 "EHLO mail-it1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726840AbeKOQqg (ORCPT ); Thu, 15 Nov 2018 11:46:36 -0500 Received: by mail-it1-f172.google.com with SMTP id j79-v6so27713925itb.2 for ; Wed, 14 Nov 2018 22:40:04 -0800 (PST) In-Reply-To: <20181113222248.2773-1-jiri@resnulli.us> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/13/18 2:22 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently, the vlan packet offloads are registered only upon 8021q module > load. However, even without this module loaded, the offloads could be > utilized, for example by openvswitch datapath. As reported by Michael, > that causes 2x to 5x performance improvement, depending on a testcase. > > So move the vlan offload registrations into vlan_core and make this > available even without 8021q module loaded. > > Reported-by: Michael Shteinbok > Signed-off-by: Jiri Pirko > Tested-by: Michael Shteinbok > --- > net/8021q/vlan.c | 96 ----------------------------------------- > net/8021q/vlan_core.c | 99 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 96 deletions(-) > Reviewed-by: David Ahern