From: David Ahern <dsahern@gmail.com>
To: Benedict Wong <benedictwong@google.com>, netdev@vger.kernel.org
Cc: nharold@google.com, lorenzo@google.com, maze@google.com
Subject: Re: [PATCH v2 iproute2 1/1] xfrm: add option to hide keys in state output
Date: Mon, 21 Jan 2019 09:33:55 -0700 [thread overview]
Message-ID: <2ee964f2-f289-cd85-edb8-4fd6959a8543@gmail.com> (raw)
In-Reply-To: <20190118191217.131649-2-benedictwong@google.com>
On 1/18/19 12:12 PM, Benedict Wong wrote:
> ip xfrm state show currently dumps keys unconditionally. This limits its
> use in logging, as security information can be leaked.
>
> This patch adds a nokeys option to ip xfrm ( state show | monitor ), which
> prevents the printing of keys. This allows ip xfrm state show to be used
> in logging without exposing keys.
>
> Signed-off-by: Benedict Wong <benedictwong@google.com>
> ---
> ip/ipxfrm.c | 49 +++++++++++++++++++++++++---------------------
> ip/xfrm.h | 5 +++--
> ip/xfrm_monitor.c | 7 +++++--
> ip/xfrm_state.c | 27 ++++++++++++++++++++-----
> man/man8/ip-xfrm.8 | 15 +++++++++++++-
> 5 files changed, 71 insertions(+), 32 deletions(-)
>
applied to iproute2-next. Thanks
prev parent reply other threads:[~2019-01-21 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 19:12 [PATCH v2 iproute2 0/1] Hide keys for state output - changelog Benedict Wong
2019-01-18 19:12 ` [PATCH v2 iproute2 1/1] xfrm: add option to hide keys in state output Benedict Wong
2019-01-21 16:33 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ee964f2-f289-cd85-edb8-4fd6959a8543@gmail.com \
--to=dsahern@gmail.com \
--cc=benedictwong@google.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nharold@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).